Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsupported JSON functions includes JSON_ARRAY_INSERT #1766

Closed
wwar opened this issue Jan 11, 2020 · 4 comments · Fixed by #3154
Closed

Unsupported JSON functions includes JSON_ARRAY_INSERT #1766

wwar opened this issue Jan 11, 2020 · 4 comments · Fixed by #3154

Comments

@wwar
Copy link

wwar commented Jan 11, 2020

Change Request

This repository is ONLY used to solve issues related to DOCS.
For other issues (related to TiDB, PD, etc), please move to other repositories.

Please answer the following questions before submitting your issue. Thanks!

  1. Describe what you find is inappropriate or missing in the existing docs.

This page https://pingcap.com/docs/dev/reference/sql/functions-and-operators/json-functions/

  1. Describe your suggestion or addition.

A minor issue: the function JSON_ARRAY_INSERT has been added.

  1. Provide some reference materials (documents, websites, etc) if you could.

It was merged in pingcap/tidb#7546
@XuHuaiyu
Copy link
Contributor

@wwar Thanks, I think you're right.

/cc @TomShawn

@TomShawn
Copy link
Contributor

TomShawn commented Feb 5, 2020

@XuHuaiyu Please help update the JSON Functions document to include the added function, thanks!

@wwar
Copy link
Author

wwar commented May 21, 2020

Actually, the page is more out of date. The only functions not supported now are:

JSON_MERGE_PATCH
JSON_PRETTY
JSON_ARRAYAGG

I manually verified.

@TomShawn
Copy link
Contributor

TomShawn commented May 21, 2020 •
edited
Loading

@XuHuaiyu Please help confirm and update the unsupported JSON function, thanks!

@ghost ghost mentioned this issue Jul 3, 2020
Merged
5 tasks
@ghost ghost assigned ghost and unassigned XuHuaiyu Jul 6, 2020
ti-srebot added a commit that referenced this issue Jul 20, 2020
@ti-srebot
functions-and-operators: Update JSON functions (#3154)
9c7e4ec 
* functions-and-operators: Update JSON functions

Fixes #1766

* Remove "syntactic sugar", use term "alias" instead

Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
@ti-srebot ti-srebot mentioned this issue Jul 20, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

functions-and-operators: Update JSON functions
3 participants
@XuHuaiyu @TomShawn @wwar