Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some point desc #10599

Merged
merged 2 commits into from
Sep 30, 2022
Merged

add some point desc #10599

merged 2 commits into from
Sep 30, 2022

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Sep 30, 2022

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added the require-LGT1 Indicates that the PR requires an LGTM. label Sep 30, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Oreoxmt Oreoxmt added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Sep 30, 2022
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 30, 2022
@Oreoxmt Oreoxmt added area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. type/bugfix This PR fixes a bug. labels Sep 30, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 30, 2022
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Sep 30, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6e0fb9e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 30, 2022
@ti-chi-bot ti-chi-bot merged commit ec83f3c into pingcap:master Sep 30, 2022
@Oreoxmt Oreoxmt deleted the translate/docs-cn-11454 branch September 30, 2022 06:22
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10606.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10607.

This was referenced Sep 30, 2022
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10608.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10609.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2022
Merged
13 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 30, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10610.

ti-chi-bot added a commit that referenced this pull request Sep 30, 2022
@ti-chi-bot
add some point desc (#10599) (#10607)
c9d6cca
ti-chi-bot added a commit that referenced this pull request Sep 30, 2022
@ti-chi-bot
add some point desc (#10599) (#10606)
827fc64
ti-chi-bot added a commit that referenced this pull request Sep 30, 2022
@ti-chi-bot
add some point desc (#10599) (#10608)
5f7c103
ti-chi-bot added a commit that referenced this pull request Sep 30, 2022
@ti-chi-bot
add some point desc (#10599) (#10609)
ba900d7
ti-chi-bot added a commit that referenced this pull request Sep 30, 2022
@ti-chi-bot
add some point desc (#10599) (#10610)
578d674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@glkappe glkappe Awaiting requested review from glkappe

Assignees
No one assigned
Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oreoxmt @ti-chi-bot @TomShawn