Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command-line-flags-for-tidb-configuration: Add missing flags #11132

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 3, 2022

What is changed, added or deleted? (Required)

Add missing flags for tidb-server.

$ diff <(path/to/tidb/bin/tidb-server -h 2>&1 | awk '/^  -/ { print $1 }' | sort) <(awk '/^##/ { print $2 }' command-line-flags-for-tidb-configuration.md | cut -d\` -f2 | sed -e 's/--/-/g' | sort)
3d2
< -alsologtostderr
9d7
< -help
11,12d8
< -initialize-insecure
< -initialize-secure
15,16d10
< -log_backtrace_at
< -log_dir
19d12
< -logtostderr
35d27
< -stderrthreshold
37d28
< -temp-dir
39d29
< -v
41d30
< -vmodule

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 3, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2022
@dveeden dveeden requested review from qiancai, TomShawn, shichun-0415 and en-jin19 and removed request for shichun-0415 November 3, 2022 07:46
@TomShawn TomShawn requested review from xhebox and removed request for en-jin19 November 3, 2022 07:53
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2022
@TomShawn TomShawn added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. add-missing-docs Add missing system variables to documentation needs-cherry-pick-release-6.3 and removed missing-translation-status This PR does not have translation status info. labels Nov 3, 2022
@TomShawn TomShawn self-assigned this Nov 3, 2022
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2022
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 3, 2022
@TomShawn
Copy link
Contributor

TomShawn commented Nov 3, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b359f71

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 3, 2022
@ti-chi-bot ti-chi-bot merged commit b3811c6 into pingcap:master Nov 3, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11133.

@TomShawn TomShawn added the ONCALL Relates to documentation oncall. label Nov 3, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-missing-docs Add missing system variables to documentation area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants