Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql-infra: add resource control feature #12353
sql-infra: add resource control feature #12353
Changes from 9 commits
896f94c
7e7d291
8c6f68e
910f132
722bd30
72d5153
3862e03
5647598
4774963
1971ca2
25f2408
4d59f3b
589edfb
bb2f7e1
4356301
d48a5d6
53822c4
e405d6e
9a4f4ba
f9d992f
5fedf74
413aba2
60f6d30
3b9915b
ee9415a
464d30c
3fa096f
e522fcd
d93d8a7
3c6e57b
e897300
7c73827
6804d8c
0aec93b
ba6590a
63381ba
b1db47c
bd7ce25
5a1207c
a46e7a0
757aa33
b3d6c4b
76494af
c8edbda
4ea89b4
cccc9a2
070ea08
235af05
71c07b0
7b6e581
0923d0b
cefd18e
155f791
0f7a666
fa3e83d
7a59a5b
b21d6b7
6c6de80
2d1f36d
5e1fd62
1c63af5
22e2cd1
c7b13a1
3ddf4a9
12e8dc4
c7fd54e
d84412f
0d85e11
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the
tidb_enable_resource_group
variable is set to on, and then set to off after 'alter resource group', then the resource control keep working.It's better for our PM to verify the behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nolouch please verify if the interception will stop working for active sessions if tidb_enable_resource_group set to off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the interception will stop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever
tidb_enable_resource_group
is set to off, we'd better to disable the control immediately. Are we talking the existing sessions cannot be altered?Moreover, we don't have to make the two operations relevant.
tidb_enable_resource_group
only controls whether the resource control takes effects or notThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.