Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link how to address TiKV_pending_task alert #13085

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Add link how to address TiKV_pending_task alert #13085

merged 2 commits into from
Apr 12, 2023

Conversation

yahonda
Copy link
Member

@yahonda yahonda commented Mar 31, 2023

What is changed, added or deleted? (Required)

This pull request adds link how to address TiKV_pending_task alert because it is not clear what to do now. Also it rewrites the statement so that it is clear that apply worker is noun. the current statement may cause misunderstanding that apply is verb.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@yahonda
Add link how to address TiKV_pending_task alert
5f343d7 
- Rewrite the statement so that it is clear that `apply worker` is noun.
the current statement may cause misunderstanding that `apply` is verb.
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 31, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 31, 2023
@Oreoxmt Oreoxmt self-assigned this Mar 31, 2023
@Oreoxmt Oreoxmt self-requested a review March 31, 2023 07:58
@Oreoxmt Oreoxmt added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 translation/doing This PR's assignee is translating this PR. labels Mar 31, 2023
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Mar 31, 2023
@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. missing-translation-status This PR does not have translation status info. area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. and removed missing-translation-status This PR does not have translation status info. labels Mar 31, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Apr 3, 2023 •
edited
Loading

@qqqdan @LykxSassinator PTAL

LykxSassinator
LykxSassinator approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@LykxSassinator LykxSassinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Oreoxmt
Oreoxmt reviewed Apr 10, 2023
View reviewed changes
alert-rules.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt self-requested a review April 10, 2023 07:52
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Apr 12, 2023

/status LGT1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 12, 2023
Oreoxmt
Oreoxmt approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 12, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Apr 12, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0bb4f70

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2023
@ti-chi-bot ti-chi-bot merged commit 331bcfb into pingcap:master Apr 12, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 12, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #13223.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 12, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #13224.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 12, 2023
Merged
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #13225.

ti-chi-bot added a commit that referenced this pull request Apr 12, 2023
@ti-chi-bot
Add link how to address TiKV_pending_task alert (#13085) (#13223)
99f2c26
ti-chi-bot added a commit that referenced this pull request Apr 12, 2023
@ti-chi-bot
Add link how to address TiKV_pending_task alert (#13085) (#13224)
0059e7f
ti-chi-bot added a commit that referenced this pull request Apr 12, 2023
@ti-chi-bot
Add link how to address TiKV_pending_task alert (#13085) (#13225)
33d61e5
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels May 8, 2023
@Oreoxmt Oreoxmt mentioned this pull request May 8, 2023
Merged
16 tasks
This was referenced May 11, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LykxSassinator LykxSassinator LykxSassinator approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yahonda @ti-chi-bot @Oreoxmt @LykxSassinator