Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Grafana Json Link #13232

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Fix Grafana Json Link #13232

merged 2 commits into from
Apr 13, 2023

Conversation

lilyjazz
Copy link
Member

@lilyjazz lilyjazz commented Apr 13, 2023 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 13, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 13, 2023
@lilyjazz @qiancai
Update tidb-cloud/monitor-prometheus-and-grafana-integration.md
b9b03ef 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 13, 2023
@qiancai qiancai added translation/no-need No need to translate this PR. require-LGT1 Indicates that the PR requires an LGTM. area/tidb-cloud This PR relates to the area of TiDB Cloud. labels Apr 13, 2023
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label Apr 13, 2023
@qiancai
Copy link
Collaborator

qiancai commented Apr 13, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b9b03ef

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 13, 2023
@ti-chi-bot ti-chi-bot merged commit 71ea684 into pingcap:release-6.5 Apr 13, 2023
gengliqi pushed a commit to gengliqi/docs that referenced this pull request Apr 17, 2023
@shichun-0415 @Oreoxmt
@hfxsd @ran-huang @qiancai @TomShawn @joey-yez @dveeden @ljun0712 @tangenta @ekexium @sdojjy
add 6.3.0 release notes (pingcap#10249)
b93f892 
* add 6.3.0 release notes

* copy new feature description in zh to en for translation

* reminding

* translate notes tw:@Oreoxmt

* Update releases/release-6.3.0.md

* Update releases/release-6.3.0.md

* Apply suggestions from code review

* Update releases/release-6.3.0.md

* Update releases/release-6.3.0.md

* Update releases/release-6.3.0.md

* Update releases/release-6.3.0.md

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>

* Apply suggestions from code review

* Update releases/release-6.3.0.md

* Update releases/release-6.3.0.md

* update

* Update releases/release-6.3.0.md

* Update releases/release-6.3.0.md

* Apply suggestions from code review

* Update releases/release-6.3.0.md

Co-authored-by: Grace Cai <qqzczy@126.com>

* Apply suggestions from code review

* Apply suggestions from code review

* add improvements and bug fixes

* apply suggestions from code review

* apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

* add 9 notes generated between 9.14 and 9.21

* Update releases/release-6.3.0.md

Co-authored-by: Daniël van Eeden <github@myname.nl>

* Update releases/release-6.3.0.md

Co-authored-by: Daniël van Eeden <github@myname.nl>

* add five more notes and non-PingCAPer contributors

* Apply suggestions from code review

* Update releases/release-6.3.0.md

* Update releases/release-6.3.0.md

* Apply suggestions from code review

Co-authored-by: Aolin <aolinz@outlook.com>

* Update releases/release-6.3.0.md

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

* Update releases/release-6.3.0.md

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

* Update releases/release-6.3.0.md

Co-authored-by: Aolin <aolinz@outlook.com>

* Update releases/release-6.3.0.md

Co-authored-by: Aolin <aolinz@outlook.com>

* Update releases/release-6.3.0.md

* Update releases/release-6.3.0.md

* Apply suggestions from code review

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

* Update release-6.3.0.md

* Update release-6.3.0.md

* Apply suggestions from code review

Co-authored-by: Grace Cai <qqzczy@126.com>

* Update releases/release-6.3.0.md

Co-authored-by: Grace Cai <qqzczy@126.com>

* Update releases/release-6.3.0.md

* refine

* Apply suggestions from code review

Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: Ran <huangran@pingcap.com>

* add compatibility changes

* Apply suggestions from code review

Co-authored-by: tangenta <tangenta@126.com>
Co-authored-by: ekexium <eke@fastmail.com>

* fix notes for tiflash (compute)

* remove notes for tidb dashboard

* Apply suggestions from code review

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

* Update releases/release-6.3.0.md

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

* Apply suggestions from code review

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

* add three tiflash notes and five br notes

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

* categorize unsorted tidb notes, add a dm note, and fix br notes

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Ran <huangran@pingcap.com>

* Update releases/release-6.3.0.md

* Apply suggestions from code review

Co-authored-by: Jianyuan Jiang <sdojjy@qq.com>

* Apply suggestions from code review

* review TiKV and PD

* Apply suggestions from code review

Co-authored-by: Ran <huangran@pingcap.com>

* Apply suggestions from code review

Co-authored-by: Aolin <aolinz@outlook.com>

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Update releases/release-6.3.0.md

* refine system variable description

* Update releases/release-6.3.0.md

* refine wording for key features

* Apply suggestions from code review

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

* refine compatibility-others

* Apply suggestions from code review

Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Daniël van Eeden <github@myname.nl>

* Update releases/release-6.3.0.md

* Update releases/release-6.3.0.md

* Update releases/release-6.3.0.md

* Update releases/release-6.3.0.md

* Update releases/release-6.3.0.md

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Grace Cai <qqzczy@126.com>

* Apply suggestions from code review

Co-authored-by: Grace Cai <qqzczy@126.com>

* Update releases/release-6.3.0.md

* Apply suggestions from code review

Co-authored-by: Grace Cai <qqzczy@126.com>

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: Grace Cai <qqzczy@126.com>

* Apply suggestions from code review

Co-authored-by: Grace Cai <qqzczy@126.com>

* Apply suggestions from code review

Co-authored-by: xixirangrang <hfxsd@hotmail.com>

* Apply suggestions from code review

Co-authored-by: Grace Cai <qqzczy@126.com>

* refine format

* Update releases/release-6.3.0.md

Co-authored-by: Aolin <aolinz@outlook.com>

* refine wording

* move a binlog fix to bug fix

* address comment on br issue pingcap#13232

* Apply suggestions from code review

Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Grace Cai <qqzczy@126.com>

* add 6.3 release to About TiDB in TOC

* address comments

* Apply suggestions from code review

Co-authored-by: Aolin <aolin.zhang@pingcap.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: joey-yez <104608045+joey-yez@users.noreply.github.com>
Co-authored-by: Daniël van Eeden <github@myname.nl>
Co-authored-by: long0712 <87366891+ljun0712@users.noreply.github.com>
Co-authored-by: tangenta <tangenta@126.com>
Co-authored-by: ekexium <eke@fastmail.com>
Co-authored-by: Jianyuan Jiang <sdojjy@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

Assignees
No one assigned
Labels
area/tidb-cloud This PR relates to the area of TiDB Cloud. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilyjazz @ti-chi-bot @qiancai