Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: changefeed supports to sink to cloud storage (s3) #13771

Merged
merged 17 commits into from
Jun 13, 2023
Merged

docs: changefeed supports to sink to cloud storage (s3) #13771

merged 17 commits into from
Jun 13, 2023

Conversation

benmaoer
Copy link
Contributor

@benmaoer benmaoer commented Jun 4, 2023 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 4, 2023

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from crazycs520 and lucklove June 4, 2023 15:49
@ti-chi-bot ti-chi-bot bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2023
@benmaoer benmaoer requested a review from cchenkey June 4, 2023 15:50
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2023

@cchenkey: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt Oreoxmt added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. labels Jun 5, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 5, 2023
@Oreoxmt Oreoxmt requested a review from ran-huang June 5, 2023 03:07
grovecai
grovecai reviewed Jun 5, 2023
View reviewed changes
tidb-cloud/changefeed-sink-to-cloud-storage.md Outdated

> ## Limitations
>
> - To use the Changefeed feature, please ensure that your TiDB cluster is running version v6.5.0 or a later version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sync CDC team, we only support sink to S3 on cloud with version >= 7.1.0 since data folder structure has incompatible changes to lower versions.

@Oreoxmt Oreoxmt requested review from Oreoxmt and removed request for lucklove and crazycs520 June 5, 2023 10:22
@Oreoxmt Oreoxmt added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. for-cloud-release This PR is related to TiDB Cloud release. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 7, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 9, 2023
ran-huang
ran-huang reviewed Jun 12, 2023
View reviewed changes
tidb-cloud/changefeed-sink-to-cloud-storage.md Outdated Show resolved Hide resolved
tidb-cloud/changefeed-sink-to-cloud-storage.md Outdated Show resolved Hide resolved
tidb-cloud/changefeed-sink-to-cloud-storage.md Outdated Show resolved Hide resolved
tidb-cloud/changefeed-sink-to-cloud-storage.md Outdated Show resolved Hide resolved
tidb-cloud/changefeed-sink-to-cloud-storage.md Outdated Show resolved Hide resolved
@ran-huang @Oreoxmt
Apply suggestions from code review
b75f52f 
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 13, 2023
Oreoxmt
Oreoxmt reviewed Jun 13, 2023
View reviewed changes
tidb-cloud/changefeed-sink-to-cloud-storage.md Outdated Show resolved Hide resolved
tidb-cloud/changefeed-sink-to-cloud-storage.md Outdated Show resolved Hide resolved
tidb-cloud/changefeed-sink-to-cloud-storage.md Outdated Show resolved Hide resolved
tidb-cloud/changefeed-sink-to-cloud-storage.md Outdated Show resolved Hide resolved
tidb-cloud/changefeed-sink-to-cloud-storage.md Outdated Show resolved Hide resolved
tidb-cloud/changefeed-sink-to-cloud-storage.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-13 05:47:34.411461672 +0000 UTC m=+64650.826065750: ☑️ agreed by ran-huang.
  • 2023-06-13 06:09:29.194963747 +0000 UTC m=+65965.609567826: ☑️ agreed by Oreoxmt.

@ran-huang @Oreoxmt
Apply suggestions from code review
da2bc52 
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2023
@Oreoxmt
Merge branch 'release-6.5' into changefeed-sink-to-s3
b20a445 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2023
@Oreoxmt
fix format
2f9e9c5 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 13, 2023

/approve
/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit 402063f into pingcap:release-6.5 Jun 13, 2023
github-actions bot pushed a commit to Oreoxmt/pingcap-docs-website-scaffold that referenced this pull request Jun 14, 2023
Preview PR pingcap/docs#13771 commit pingcap/docs@2f9e9c5
5110c4e
github-actions bot pushed a commit to Oreoxmt/pingcap-docs-website-scaffold that referenced this pull request Jun 14, 2023
Preview PR pingcap/docs#13771 and this preview is trigged from commit p…
e8620dd 
…ingcap/docs@2f9e9c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchenkey cchenkey cchenkey approved these changes

@grovecai grovecai grovecai left review comments

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@ran-huang ran-huang ran-huang approved these changes

Assignees
No one assigned
Labels
approved area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@benmaoer @Oreoxmt @grovecai @cchenkey @ran-huang