Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tidb-lightning-physical-import-mode.md #13777

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Update tidb-lightning-physical-import-mode.md #13777

merged 1 commit into from
Jun 6, 2023

Conversation

Frank945946
Copy link
Contributor

@Frank945946 Frank945946 commented Jun 5, 2023 •
edited by hfxsd
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Frank945946 Frank945946 added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jun 5, 2023
@ti-chi-bot ti-chi-bot bot requested a review from crazycs520 June 5, 2023 07:02
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2023
@hfxsd hfxsd added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. and removed missing-translation-status This PR does not have translation status info. labels Jun 6, 2023
@hfxsd hfxsd requested review from okJiang and removed request for okJiang June 6, 2023 02:07
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 6, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 6, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-06 02:10:24.804073222 +0000 UTC m=+314211.077046001: ☑️ agreed by hfxsd.
  • 2023-06-06 02:11:39.803988978 +0000 UTC m=+314286.076961762: ☑️ agreed by Oreoxmt.

qiancai
qiancai approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

qiancai
qiancai approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

qiancai
qiancai approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

qiancai
qiancai approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd, Oreoxmt, qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Oreoxmt,hfxsd,qiancai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd, Oreoxmt, qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Oreoxmt,hfxsd,qiancai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit dcdb134 into master Jun 6, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #13788.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 6, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #13789.

This was referenced Jun 6, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #13790.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 6, 2023
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.6: #13791.

ti-chi-bot bot pushed a commit that referenced this pull request Jun 6, 2023
@ti-chi-bot
Update tidb-lightning-physical-import-mode.md (#13777) (#13790)
e0ccbe9
ti-chi-bot bot pushed a commit that referenced this pull request Jun 6, 2023
@ti-chi-bot
Update tidb-lightning-physical-import-mode.md (#13777) (#13788)
586069a
ti-chi-bot bot pushed a commit that referenced this pull request Jun 6, 2023
@ti-chi-bot
Update tidb-lightning-physical-import-mode.md (#13777) (#13789)
40826c2
ti-chi-bot bot pushed a commit that referenced this pull request Jun 6, 2023
@ti-chi-bot
Update tidb-lightning-physical-import-mode.md (#13777) (#13791)
9303b40
@lilin90 lilin90 deleted the Frank945946-patch-2 branch August 7, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@hfxsd hfxsd hfxsd approved these changes

@crazycs520 crazycs520 Awaiting requested review from crazycs520

Assignees

@hfxsd hfxsd

Labels
approved area/tidb-lightning Indicates that the Issue or PR belongs to the area of TiDB Lightning. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Frank945946 @ti-chi-bot @hfxsd @Oreoxmt @qiancai