Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update default values for RocksDB config #14129

Merged
merged 4 commits into from
Aug 7, 2023
Merged

update default values for RocksDB config #14129

merged 4 commits into from
Aug 7, 2023

Conversation

tabokie
Copy link
Contributor

@tabokie tabokie commented Jul 5, 2023 •
edited
Loading

What is changed, added or deleted? (Required)

tikv/tikv#15055
tikv/tikv#15115
tikv/tikv#15174

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@tabokie
update default values for RocksDB config
9519168 
Signed-off-by: tabokie <xy.tao@outlook.com>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 5, 2023
@Oreoxmt Oreoxmt added translation/doing This PR's assignee is translating this PR. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 5, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jul 5, 2023
@Oreoxmt Oreoxmt added missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed missing-translation-status This PR does not have translation status info. labels Jul 5, 2023
@Oreoxmt Oreoxmt self-assigned this Jul 5, 2023
@Oreoxmt Oreoxmt self-requested a review July 5, 2023 10:03
@tabokie tabokie removed the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Jul 24, 2023
@tabokie
update
40de158 
Signed-off-by: tabokie <xy.tao@outlook.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2023
@tabokie tabokie mentioned this pull request Jul 24, 2023
Merged
@tabokie
update
79ed454 
Signed-off-by: tabokie <xy.tao@outlook.com>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 24, 2023

@tabokie Are the compatibility changes involved in this PR introduced in v7.3?

@tabokie
Copy link
Contributor Author

tabokie commented Jul 24, 2023

7.3 branch is not cut, all the changes on master branch before the cut will be in 7.3 release.

@Oreoxmt Oreoxmt added type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.3 This PR/issue applies to TiDB v7.3. for-release This PR relates to a TiDB release but does not have a tracked feature. labels Jul 25, 2023
Oreoxmt
Oreoxmt reviewed Jul 27, 2023
View reviewed changes
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
tikv-configuration-file.md Outdated Show resolved Hide resolved
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 27, 2023

@tabokie
Could you please invite a tech reviewer? Thanks!

@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 27, 2023
@Oreoxmt Oreoxmt mentioned this pull request Jul 27, 2023
Merged
17 tasks
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 27, 2023

@tonyxuqqi: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tabokie @Oreoxmt
Apply suggestions from code review
c5cc507 
Co-authored-by: Aolin <aolinz@outlook.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 27, 2023
@Oreoxmt Oreoxmt requested a review from hfxsd July 27, 2023 10:07
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-27 10:07:06.985536893 +0000 UTC m=+435369.580067869: ☑️ agreed by Oreoxmt.
  • 2023-07-28 02:36:47.930639595 +0000 UTC m=+494750.525170580: ☑️ agreed by hfxsd.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Aug 7, 2023

/approve
/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit 419d182 into pingcap:master Aug 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@hfxsd hfxsd hfxsd approved these changes

@tonyxuqqi tonyxuqqi tonyxuqqi approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v7.3 This PR/issue applies to TiDB v7.3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tabokie @Oreoxmt @tonyxuqqi @hfxsd