Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the support page instead of direct links #15402

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 21, 2023

What is changed, added or deleted? (Required)

The right support channel might depend on:

  • Region (US, EMEA, China, ASIA)
  • Service (TiDB Cloud, On prem)
  • Support contract (Enterprise or Community)
  • Type of request (Question on Slack, bugreport on GitHub, support on zendesk/jirasd)

So best to link to https://docs.pingcap.com/tidb/stable/support instead.

I have left:

Maybe we should add a link to email or otherwise reach sales to support.md.

Previous PR: #14648

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added area/develop This PR relates to the area of TiDB App development. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 24, 2023
Copy link

ti-chi-bot bot commented Nov 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-24 07:33:09.343397803 +0000 UTC m=+562418.008623998: ☑️ agreed by ran-huang.

@dveeden
Copy link
Contributor Author

dveeden commented Nov 24, 2023

@ran-huang Is this working correctly for TiDB Cloud as well? Looks like TOC-tidb-cloud.md doesn't have a link to support.md.

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2023
@ran-huang
Copy link
Contributor

@ran-huang Is this working correctly for TiDB Cloud as well? Looks like TOC-tidb-cloud.md doesn't have a link to support.md.

@dveeden No worries, I've fixed the link check.

@ran-huang ran-huang added the translation/doing This PR's assignee is translating this PR. label Nov 24, 2023
@ran-huang ran-huang self-assigned this Nov 24, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 24, 2023
@ran-huang ran-huang added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Nov 24, 2023
@ran-huang
Copy link
Contributor

/approve

@ran-huang ran-huang added the lgtm label Nov 24, 2023
Copy link

ti-chi-bot bot commented Nov 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 24, 2023
@ti-chi-bot ti-chi-bot bot merged commit 101e17d into pingcap:master Nov 24, 2023
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #15462.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/develop This PR relates to the area of TiDB App development. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/doing This PR's assignee is translating this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants