Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions: Add examples for bit functions and operators #18253

Merged
merged 13 commits into from
Jul 31, 2024
Merged

Functions: Add examples for bit functions and operators #18253

merged 13 commits into from
Jul 31, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jul 16, 2024 •
edited by qiancai
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from mjonss, hfxsd and qiancai July 16, 2024 07:11
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 16, 2024
@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 24, 2024
@qiancai qiancai self-assigned this Jul 29, 2024
mjonss
mjonss approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor suggestion

functions-and-operators/bit-functions-and-operators.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 29, 2024

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM with a minor suggestion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai
Copy link
Collaborator

qiancai commented Jul 30, 2024 •
edited
Loading

Hi @dveeden, I've submitted some changes https://github.com/pingcap/docs/pull/18253/files/f8b1e797e52661dd88f685527305bc955dc34dbe..41783185d753ae58238354e276b188c36b603e7f as comments. Would you please take a look at them? Thanks.

@qiancai qiancai mentioned this pull request Jul 30, 2024
Merged
16 tasks
hfxsd
hfxsd approved these changes Jul 31, 2024
View reviewed changes
functions-and-operators/bit-functions-and-operators.md Outdated Show resolved Hide resolved
functions-and-operators/bit-functions-and-operators.md Outdated Show resolved Hide resolved
functions-and-operators/bit-functions-and-operators.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 31, 2024
qiancai and others added 3 commits July 31, 2024 11:19
@qiancai qiancai added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. labels Jul 31, 2024
@qiancai qiancai added type/enhancement The issue or PR belongs to an enhancement. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 31, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 31, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-31 02:38:04.669205352 +0000 UTC m=+323400.949253420: ☑️ agreed by hfxsd.
  • 2024-07-31 04:10:13.163926453 +0000 UTC m=+328929.443974546: ☑️ agreed by qiancai.

@qiancai
Copy link
Collaborator

qiancai commented Jul 31, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 31, 2024
This was referenced Jul 31, 2024
Merged
Merged
@ti-chi-bot ti-chi-bot bot merged commit ec18ed8 into pingcap:master Jul 31, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18430.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 31, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #18431.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 31, 2024
Merged
16 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jul 31, 2024
@ti-chi-bot
Functions: Add examples for bit functions and operators (#18253) (#18431
45594c3 
)
ti-chi-bot bot pushed a commit that referenced this pull request Jul 31, 2024
@ti-chi-bot
Functions: Add examples for bit functions and operators (#18253) (#18430
83bf51e 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjonss mjonss mjonss approved these changes

@hfxsd hfxsd hfxsd approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@qiancai qiancai

Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dveeden @qiancai @ti-chi-bot @mjonss @hfxsd