Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more links and corrections to user account management #18283

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Jul 18, 2024

What is changed, added or deleted? (Required)

  • Add links where appropriate
  • Minor corrections

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2024
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 18, 2024

  • Looks like skip-grant-tables isn't documented on tidb-configuration-file.md. Is this on purpose?

@tiancaiamao Could you please take a look at this issue?

@dveeden
Copy link
Contributor Author

dveeden commented Jul 18, 2024

  • Looks like skip-grant-tables isn't documented on tidb-configuration-file.md. Is this on purpose?

@tiancaiamao Could you please take a look at this issue?

https://github.com/pingcap/tidb/blob/035f79e896b607cb6edec32a59db6a352304ff9a/pkg/config/config.go#L593 is where this is in the code.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 18, 2024

  • For "Reserved user accounts" we might have to add cloud_admin and/or role_admin for TiDB Cloud?

@zhoubasten Could you please take a look at this?

TiDB > Reserved user accounts: https://docs.pingcap.com/tidb/stable/user-account-management#reserved-user-accounts
TiDB Cloud > Roles of database users:https://docs.pingcap.com/tidbcloud/configure-sql-users#roles-of-database-users

@Oreoxmt Oreoxmt self-assigned this Jul 18, 2024
@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. translation/doing This PR's assignee is translating this PR. labels Jul 18, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jul 18, 2024
Copy link

ti-chi-bot bot commented Jul 19, 2024

@CbcWestwolf: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CbcWestwolf
Copy link
Member

CbcWestwolf commented Jul 19, 2024

  • Looks like skip-grant-tables isn't documented on tidb-configuration-file.md. Is this on purpose?

I think we just missed it.

  • For "Reserved user accounts" we might have to add cloud_admin and/or role_admin for TiDB Cloud?

Maybe it is better to decribe these users/roles in tidb cloud documentation for maintainability.

  • There is only a page for mysql.*, not one that specifically explains the fields and details of mysql.user

Let me add the description about mysql.user later :-)

@tiancaiamao
Copy link
Contributor

  • Looks like skip-grant-tables isn't documented on tidb-configuration-file.md. Is this on purpose?

I think we just missed it.

  • For "Reserved user accounts" we might have to add cloud_admin and/or role_admin for TiDB Cloud?

Maybe it is better to decribe thiese users/roles in tidb cloud documentation for maintainability.

  • There is only a page for mysql.*, not one that specifically explains the fields and details of mysql.user

Let me add the description about mysql.user later :-)

skip-grant-table is not exposed ... it's used when someone forget his password:
set this to true, modify password, and reset it.
It's not a general functionality, and doesn't even work well if we keep running with it.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 19, 2024
privilege-management.md Outdated Show resolved Hide resolved
privilege-management.md Outdated Show resolved Hide resolved
privilege-management.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-alter-user.md Outdated Show resolved Hide resolved
user-account-management.md Outdated Show resolved Hide resolved
Co-authored-by: Aolin <aolinz@outlook.com>
privilege-management.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 23, 2024
dveeden and others added 2 commits July 23, 2024 11:44
Co-authored-by: Aolin <aolinz@outlook.com>
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

user-account-management.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 24, 2024
Copy link

ti-chi-bot bot commented Jul 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-19 09:35:34.211716548 +0000 UTC m=+605756.202658019: ☑️ agreed by tiancaiamao.
  • 2024-07-24 08:45:20.080571039 +0000 UTC m=+1034742.071512507: ☑️ agreed by qiancai.

Co-authored-by: Grace Cai <qqzczy@126.com>
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 24, 2024

/approve

Copy link

ti-chi-bot bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 24, 2024
@ti-chi-bot ti-chi-bot bot merged commit 6dee652 into pingcap:master Jul 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants