Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc: remove maxwell protocol, add simple protocol #18286

Merged
merged 1 commit into from
Jul 29, 2024
Merged

cdc: remove maxwell protocol, add simple protocol #18286

merged 1 commit into from
Jul 29, 2024

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Jul 18, 2024 •
edited
Loading

What is changed, added or deleted? (Required)

  • Remove the maxwell protocol from TiCDC
  • Add the simple and debezium protocol (starting from v8.0.0)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. ONCALL Relates to documentation oncall. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.0 needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jul 18, 2024
@Oreoxmt Oreoxmt self-assigned this Jul 18, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 18, 2024
@Oreoxmt Oreoxmt requested a review from 3AceShowHand July 18, 2024 08:08
@Oreoxmt Oreoxmt added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.6 labels Jul 18, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 18, 2024

@3AceShowHand: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 18, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Jul 18, 2024

/cc @benmeadowcroft

@ti-chi-bot ti-chi-bot bot requested a review from benmeadowcroft July 18, 2024 08:51
@lilin90 lilin90 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2024
@qiancai
Copy link
Collaborator

qiancai commented Jul 19, 2024

Removed the needs-cherry-pick-release-7.6 label because the v7.6 docs have been archived at https://docs-archive.pingcap.com/tidb/v7.6 and will no longer receive new updates.

@Oreoxmt Oreoxmt force-pushed the translate/docs-cn-18030 branch from cfd067f to ae21042 Compare July 23, 2024 07:40
@Oreoxmt Oreoxmt added requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. and removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Jul 23, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 29, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18392.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 29, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #18393.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 29, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #18394.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 29, 2024
Merged
16 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jul 29, 2024
@ti-chi-bot
cdc: remove maxwell protocol, add simple protocol (#18286) (#18393)
2dafad6
ti-chi-bot bot pushed a commit that referenced this pull request Jul 29, 2024
@ti-chi-bot
cdc: remove maxwell protocol, add simple protocol (#18286) (#18392)
850b96e
ti-chi-bot bot pushed a commit that referenced this pull request Jul 29, 2024
@ti-chi-bot
cdc: remove maxwell protocol, add simple protocol (#18286) (#18391)
0cc2697
ti-chi-bot bot pushed a commit that referenced this pull request Jul 29, 2024
@ti-chi-bot
cdc: remove maxwell protocol, add simple protocol (#18286) (#18394)
1160553
This was referenced Jul 29, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 29, 2024
@ti-chi-bot @Oreoxmt
cdc: remove maxwell protocol, add simple protocol (pingcap#18286) (pi…
3893998 
…ngcap#18394)
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 29, 2024
@ti-chi-bot @Oreoxmt
cdc: remove maxwell protocol, add simple protocol (pingcap#18286) (pi…
d12d951 
…ngcap#18394)
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 29, 2024
@ti-chi-bot @Oreoxmt
cdc: remove maxwell protocol, add simple protocol (pingcap#18286) (pi…
460ed0b 
…ngcap#18394)
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 29, 2024
@ti-chi-bot @Oreoxmt
cdc: remove maxwell protocol, add simple protocol (pingcap#18286) (pi…
77da0a8 
…ngcap#18394)
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 29, 2024
@ti-chi-bot @Oreoxmt
cdc: remove maxwell protocol, add simple protocol (pingcap#18286) (pi…
84e7f96 
…ngcap#18394)
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 29, 2024
@ti-chi-bot @Oreoxmt
cdc: remove maxwell protocol, add simple protocol (pingcap#18286) (pi…
3b8e352 
…ngcap#18394)
ti-chi-bot bot pushed a commit that referenced this pull request Jul 29, 2024
@ti-chi-bot
cdc: remove maxwell protocol, add simple protocol (#18286) (#18394) (#…
788e337 
…18396)
ti-chi-bot bot pushed a commit that referenced this pull request Jul 29, 2024
@ti-chi-bot
cdc: remove maxwell protocol, add simple protocol (#18286) (#18394) (#…
3a716d8 
…18395)
ti-chi-bot bot pushed a commit that referenced this pull request Jul 29, 2024
@ti-chi-bot
cdc: remove maxwell protocol, add simple protocol (#18286) (#18394) (#…
bc413dc 
…18399)
ti-chi-bot bot pushed a commit that referenced this pull request Jul 29, 2024
@ti-chi-bot
cdc: remove maxwell protocol, add simple protocol (#18286) (#18394) (#…
1331731 
…18398)
ti-chi-bot bot pushed a commit that referenced this pull request Jul 29, 2024
@ti-chi-bot
cdc: remove maxwell protocol, add simple protocol (#18286) (#18394) (#…
dd15e06 
…18400)
ti-chi-bot bot pushed a commit that referenced this pull request Jul 29, 2024
@ti-chi-bot
cdc: remove maxwell protocol, add simple protocol (#18286) (#18394) (#…
89e7b9b 
…18397)
@Oreoxmt Oreoxmt deleted the translate/docs-cn-18030 branch December 31, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@benmeadowcroft benmeadowcroft Awaiting requested review from benmeadowcroft

Assignees

@Oreoxmt Oreoxmt

Labels
approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. ONCALL Relates to documentation oncall. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Oreoxmt @qiancai @hfxsd @ti-chi-bot @flowbehappy @3AceShowHand @lilin90