Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system-variable: add a warning for tidb_partition_prune_mode #19449

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Nov 18, 2024

What is changed, added or deleted? (Required)

Deprecated static prune mode, ref pingcap/tidb#56490

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.4 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. for-release This PR relates to a TiDB release but does not have a tracked feature. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.5 labels Nov 18, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2024
@lilin90 lilin90 self-assigned this Nov 18, 2024
@lilin90 lilin90 changed the title system-variable: add a warning message for tidb_partition_prune_mode variable system-variable: add a warning for tidb_partition_prune_mode variable Nov 18, 2024
@lilin90 lilin90 changed the title system-variable: add a warning for tidb_partition_prune_mode variable system-variable: add a warning for tidb_partition_prune_mode Nov 18, 2024
Copy link

ti-chi-bot bot commented Nov 18, 2024

@Defined2014: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please also add the same warnings in the output as in https://github.com/pingcap/docs-cn/pull/18857/files

Copy link

ti-chi-bot bot commented Nov 18, 2024

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM, but please also add the same warnings in the output as in https://github.com/pingcap/docs-cn/pull/18857/files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 19, 2024
Copy link

ti-chi-bot bot commented Nov 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-19 07:18:20.623450392 +0000 UTC m=+945462.814319389: ☑️ agreed by hfxsd.

@hfxsd hfxsd added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Nov 19, 2024
@lilin90 lilin90 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 22, 2024
@lilin90
Copy link
Member Author

lilin90 commented Nov 22, 2024

/approve

Copy link

ti-chi-bot bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 22, 2024
@lilin90 lilin90 added the lgtm label Nov 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit 66f85be into pingcap:master Nov 22, 2024
9 checks passed
@lilin90 lilin90 deleted the static-prune-18857 branch November 22, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved for-release This PR relates to a TiDB release but does not have a tracked feature. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants