Skip to content

partitioned-table: global index supports non-unique index #19944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 20, 2025
Merged

partitioned-table: global index supports non-unique index #19944

merged 3 commits into from
Mar 20, 2025

Conversation

Defined2014
Copy link
Contributor

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Defined2014 Defined2014 requested review from mjonss and qiancai and removed request for mjonss January 9, 2025 02:08
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2025
@Defined2014 Defined2014 requested review from hfxsd and mjonss January 9, 2025 02:08
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Jan 13, 2025
@hfxsd hfxsd added the v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1. label Jan 13, 2025
@hfxsd hfxsd requested review from Oreoxmt and removed request for hfxsd January 13, 2025 00:20
mjonss
mjonss approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only suggestion to be more verbose for UPDATE INDEXES.
Also one of the limitation removals should probably be its own issue.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 13, 2025

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM, only suggestion to be more verbose for UPDATE INDEXES.
Also one of the limitation removals should probably be its own issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014 Defined2014 force-pushed the support-non-unique-global-index branch from 4c0ba14 to 38f08bd Compare January 14, 2025 02:01
@Defined2014 Defined2014 force-pushed the support-non-unique-global-index branch from 38f08bd to 2b39ecb Compare January 14, 2025 02:03
qiancai
qiancai approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 13, 2025
Defined2014
Defined2014 commented Mar 17, 2025
View reviewed changes
Copy link
Contributor Author

@Defined2014 Defined2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Defined2014 @qiancai
Apply suggestions from code review
b73f6ed 
Co-authored-by: Grace Cai <qqzczy@126.com>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 17, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-13 03:36:51.306052497 +0000 UTC m=+500453.702274558: ☑️ agreed by qiancai.
  • 2025-03-17 09:45:26.070053911 +0000 UTC m=+262419.754289992: ☑️ agreed by Oreoxmt.

@qiancai
Copy link
Collaborator

qiancai commented Mar 20, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 20, 2025
@ti-chi-bot ti-chi-bot bot merged commit 9a9a260 into pingcap:master Mar 20, 2025
9 checks passed
@qiancai qiancai added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Oct 9, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #21879.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 9, 2025
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjonss mjonss mjonss approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@qiancai qiancai

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v9.0-beta.1 This PR/issue applies to TiDB v9.0-beta.1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Defined2014 @qiancai @ti-chi-bot @mjonss @Oreoxmt @hfxsd