-
Notifications
You must be signed in to change notification settings - Fork 704
planner: Add optimizer risk variables #21339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
terry1purcell
wants to merge
8
commits into
pingcap:master
Choose a base branch
from
terry1purcell:riskratio
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−0
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e81725f
planner: Add optimizer risk variables
terry1purcell 0e1001c
Update system-variables.md
terry1purcell 8c45655
Update system-variables.md
terry1purcell 6bc8cd4
Update system-variables.md
terry1purcell 624b22c
Update system-variables.md
terry1purcell 9c4d5d0
Update system-variables.md
terry1purcell 3bdf7ac
Apply suggestions from code review
hfxsd 05fd580
Apply suggestion from @hfxsd
hfxsd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4625,6 +4625,32 @@ SHOW WARNINGS; | |
</details> | ||
### tidb_opt_risk_eq_skew_ratio <span class="version-mark">New in v9.0.0</span> | ||
> **Warning:** | ||
> | ||
> The TiDB query optimizer uses this variable. Do not adjust this variable without guidance from TiDB support or engineering. | ||
- Scope: SESSION | GLOBAL | ||
- Applies to hint [SET_VAR](/optimizer-hints.md#set_varvar_namevar_value): Yes | ||
- Type: Float | ||
- Range: `[0, 1]` | ||
- Default value: `0` | ||
- This variable controls the ratio of risk between the original predicate selectivity estimate and the potential skew estimate for an equality predicate, when the value is not found in TopN or histogram buckets. | ||
hfxsd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
### tidb_opt_risk_range_skew_ratio <span class="version-mark">New in v9.0.0</span> | ||
> **Warning:** | ||
> | ||
> The TiDB query optimizer uses this variable. Do not adjust this variable without guidance from TiDB support or engineering. | ||
- Scope: SESSION | GLOBAL | ||
- Applies to hint [SET_VAR](/optimizer-hints.md#set_varvar_namevar_value): Yes | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto |
||
- Type: Float | ||
- Range: `[0, 1]` | ||
- Default value: `0` | ||
- This variable controls the ratio of risk between the original predicate selectivity estimate and the potential skew estimate for a range predicate, when the search range is found within a single histogram bucket or entirely outside the range of all histogram buckets. | ||
### tidb_opt_scan_factor | ||
- Scope: SESSION | GLOBAL | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add this? - Persists to cluster: Yes