Skip to content

Conversation

@ljun0712
Copy link
Contributor

What is changed, added or deleted? (Required)

This document introduces TLS connections for TiDB Cloud premium instances, detailing prerequisites, secure connection methods, and certificate management.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

This document introduces TLS connections for TiDB Cloud premium instances, detailing prerequisites, secure connection methods, and certificate management.
@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Oct 29, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @ljun0712, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new documentation aimed at guiding users through the process of establishing secure TLS connections to TiDB Cloud premium instances. The new content outlines prerequisites, provides detailed steps for connecting, explains certificate management, and addresses common questions regarding supported TLS versions and authentication methods. This addition significantly enhances the clarity and security guidance available to users of premium instances.

Highlights

  • New Documentation for TLS Connections: A new comprehensive document has been added that details how to establish TLS connections to TiDB Cloud premium instances, covering various aspects of secure connectivity.
  • Security Standards and Supported Versions: The documentation specifies that premium instances support TLS 1.2 and TLS 1.3, and highlights that CA certificates are sourced from AWS Private Certificate Authority, meeting FIPS 140-2 Level 3 security standards.
  • Step-by-Step Connection Guide: Users are provided with a clear, step-by-step guide on how to securely connect to their premium instances via the TiDB Cloud console, including instructions for downloading the necessary CA certificate.
  • Clarification on TLS Authentication and Configuration: The document clarifies that only one-way TLS authentication is currently supported and that the require_secure_transport variable is not user-configurable on premium instances.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new documentation page about establishing TLS connections to TiDB Cloud premium instances. My review focuses on improving clarity, conciseness, and consistency, following the repository's style guide. I've suggested several wording improvements to make the document easier to understand, corrected inconsistent terminology (e.g., 'CA cert' vs. 'CA certificate'), and recommended removing a redundant section to improve the document's structure.

@qiancai qiancai self-assigned this Oct 29, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiancai qiancai added area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants