Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how-to/troubleshoot: add tidb diagnose map #2440

Merged
merged 19 commits into from
May 12, 2020
Merged

how-to/troubleshoot: add tidb diagnose map #2440

merged 19 commits into from
May 12, 2020

Conversation

ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Apr 30, 2020

What is changed, added or deleted? (Required)

Add TiDB troubleshooting diagnose map.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@ran-huang ran-huang added the size/large Changes of a large size. label Apr 30, 2020
@ran-huang ran-huang requested a review from lilin90 April 30, 2020 14:39
@shenli
Copy link
Member

shenli commented May 3, 2020

is there a counterpart in Chinese in the docs-cn repo?

@ran-huang
Copy link
Contributor Author

is there a counterpart in Chinese in the docs-cn repo?

Not yet. The Chinese version needs some modification.

@ran-huang ran-huang changed the title faq: add tidb diagnose map how-to/troubleshoot: add tidb diagnose map May 6, 2020
@ran-huang
Copy link
Contributor Author

ran-huang commented May 6, 2020

Five deadlinks in the original file: case-517, case-1004, case-275, case-852, case-764.

Confirmed with @zhangjinpeng1987 that these cases can be removed.

@ran-huang ran-huang added needs-cherry-pick-2.1 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels May 6, 2020
@lilin90
Copy link
Member

lilin90 commented May 7, 2020

@ran-huang Got it. Then please help remove those broken links directly. Thanks!

@ran-huang
Copy link
Contributor Author

@ran-huang Got it. Then please help remove those broken links directly. Thanks!

@lilin90 I suggest commenting these links out. Should the case links turn valid again, it could save us a lot of trouble of re-adding them. PTAL at my new commit.

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments, till line 88.

how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
@ran-huang
Copy link
Contributor Author

@lilin90 Comments addressed. PTAL~

ran-huang and others added 2 commits May 11, 2020 19:58
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
how-to/troubleshoot/diagnose-map.md Outdated Show resolved Hide resolved
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@ran-huang ran-huang requested a review from Ishiihara May 12, 2020 06:10
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ran-huang
Copy link
Contributor Author

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 12, 2020

/run-all-tests

@sre-bot sre-bot merged commit c981ae7 into pingcap:master May 12, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request May 12, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 12, 2020

cherry pick to release-2.1 in PR #2531

@sre-bot
Copy link
Contributor

sre-bot commented May 12, 2020

cherry pick to release-3.0 in PR #2532

@sre-bot
Copy link
Contributor

sre-bot commented May 12, 2020

cherry pick to release-3.1 in PR #2533

@sre-bot
Copy link
Contributor

sre-bot commented May 12, 2020

cherry pick to release-4.0 in PR #2534

ran-huang added a commit that referenced this pull request May 12, 2020
Co-authored-by: Ran <huangran@pingcap.com>
ran-huang added a commit that referenced this pull request May 12, 2020
Co-authored-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang deleted the diagnose-map branch May 12, 2020 10:54
ran-huang added a commit that referenced this pull request May 12, 2020
Co-authored-by: Ran <huangran@pingcap.com>
ran-huang added a commit that referenced this pull request May 12, 2020
Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/large Changes of a large size. status/can-merge Indicates a PR has been approved by a committer. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants