Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: update address and advertise address #2526

Merged
merged 2 commits into from
May 13, 2020
Merged

Conversation

overvenus
Copy link
Member

What is changed, added or deleted? (Required)

Update CDC configuration, replace status-addr with addr and advertise-addr.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

If you select two or more versions from above, to trigger the bot to cherry-pick this PR to your desired release version branch(es), you must add corresponding labels such as needs-cherry-pick-4.0, needs-cherry-pick-3.1, needs-cherry-pick-3.0, and needs-cherry-pick-2.1.

What is the related PR or file link(s)?

@TomShawn TomShawn self-assigned this May 12, 2020
@TomShawn TomShawn added size/small Changes of a small size. translation/doing This PR's assignee is translating this PR. labels May 12, 2020
@TomShawn
Copy link
Contributor

LGTM

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added the status/LGT2 Indicates that a PR has LGTM 2. label May 13, 2020
@TomShawn TomShawn merged commit 885da4e into master May 13, 2020
sre-bot pushed a commit to sre-bot/docs that referenced this pull request May 13, 2020
Co-authored-by: amyangfei <amyangfei@gmail.com>
@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2020

cherry pick to release-4.0 in PR #2540

@TomShawn TomShawn removed the translation/doing This PR's assignee is translating this PR. label May 18, 2020
@lilin90 lilin90 deleted the overvenus-patch-1-1 branch August 5, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants