Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add declaration for scopes of transaction related variables and configurations #5056

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Add declaration for scopes of transaction related variables and configurations #5056

merged 1 commit into from
Mar 18, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Mar 18, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

There are 3 variables and configurations to control the retrial of transactions:

Optimistic transactions: tidb_disable_txn_auto_retry and tidb_retry_limit.
Pessimistic transactions: max-retry-count.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 18, 2021
@Joyinqin Joyinqin changed the title Add declaration for scopes of transaction related variables and confi… Add declaration for scopes of transaction related variables and configurations Mar 18, 2021
@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-5.0

@Joyinqin
Copy link
Contributor Author

/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Mar 18, 2021
@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-3.0

@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-3.1

@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-4.0

@Joyinqin
Copy link
Contributor Author

/cc TomShawn

@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 18, 2021
@TomShawn
Copy link
Contributor

/cc @CharLotteiu

@CharLotteiu
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharLotteiu
  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2021
@CharLotteiu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cf43a29

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2021
@ti-chi-bot ti-chi-bot merged commit e80ff2e into pingcap:master Mar 18, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 18, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5056 to release-3.0
36c3e25 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 18, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #5057

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 18, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5056 to release-3.1
c933e86 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 18, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #5058

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 18, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5056 to release-4.0
f2ba0c3 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 18, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5059

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Mar 18, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5056 to release-5.0
9cdad9e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 18, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5060

@Joyinqin Joyinqin deleted the txn-mode branch March 18, 2021 06:06
ti-chi-bot pushed a commit that referenced this pull request Mar 18, 2021
@ti-srebot
Add declaration for scopes of transaction related variables and confi…
afa950c 
…gurations (#5056) (#5060)
ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021
@ti-srebot
Add declaration for scopes of transaction related variables and confi…
c2d9aaa 
…gurations (#5056) (#5057)
ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021
@ti-srebot
Add declaration for scopes of transaction related variables and confi…
1feff49 
…gurations (#5056) (#5058)
ti-chi-bot pushed a commit that referenced this pull request Apr 13, 2021
@ti-srebot
Add declaration for scopes of transaction related variables and confi…
f6f3c40 
…gurations (#5056) (#5059)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn Awaiting requested review from TomShawn

@CharLotteiu CharLotteiu Awaiting requested review from CharLotteiu

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Joyinqin @TomShawn @CharLotteiu @ti-chi-bot @ti-srebot