Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dumpling: update dumpling document on how to reduce memory usage #5309

Merged
merged 3 commits into from
Apr 19, 2021
Merged

dumpling: update dumpling document on how to reduce memory usage #5309

merged 3 commits into from
Apr 19, 2021

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

Update dumpling document on how to reduce memory usage. Make sure users can get this important infomation.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2021
@TomShawn
Copy link
Contributor Author

/cc @yikeke @lichunzhu
/status PTAL
/translation from-docs-cn
/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/label require-LGT1

@ti-chi-bot ti-chi-bot added status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Apr 13, 2021
@yikeke yikeke requested review from lilin90 and removed request for yikeke April 13, 2021 09:16
@lichunzhu
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2021
lilin90
lilin90 reviewed Apr 14, 2021
View reviewed changes
dumpling-overview.md Outdated Show resolved Hide resolved
dumpling-overview.md Outdated Show resolved Hide resolved
dumpling-overview.md Outdated Show resolved Hide resolved
@TomShawn @lilin90
Apply suggestions from code review
a202bcd 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2021
@lilin90
Copy link
Member

lilin90 commented Apr 19, 2021

/lgtm

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2021
@lilin90
Copy link
Member

lilin90 commented Apr 19, 2021

/lgtm

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2021
@ti-chi-bot
Copy link
Member

@TomShawn: These labels are not set on the issue: status/lgt1.

In response to this:

/remove-status LGT1
/status-LGT2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor Author

/remove-status LGT1
/status LGT2

@ti-chi-bot
Copy link
Member

@TomShawn: These labels are not set on the issue: status/lgt1.

In response to this:

/remove-status LGT1
/status LGT2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Apr 19, 2021
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 261dbfb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2021
@ti-chi-bot ti-chi-bot merged commit f5cb16e into pingcap:master Apr 19, 2021
@TomShawn TomShawn deleted the updatedumpling-usage branch April 19, 2021 02:38
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 19, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5309 to release-4.0
c74d8fb 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 19, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5380

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 19, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5309 to release-5.0
1919247 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 19, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5381

ti-chi-bot pushed a commit that referenced this pull request Apr 19, 2021
@ti-srebot
dumpling: update dumpling document on how to reduce memory usage (#5309…
58939ef 
…) (#5380)
ti-chi-bot pushed a commit that referenced this pull request Apr 19, 2021
@ti-srebot
dumpling: update dumpling document on how to reduce memory usage (#5309…
c88c86b 
…) (#5381)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 left review comments

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TomShawn @lichunzhu @ti-chi-bot @lilin90 @ti-srebot