Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiUP: Add tiup-dm-topology-reference.md #5318

Merged
merged 17 commits into from
Apr 16, 2021
Merged

TiUP: Add tiup-dm-topology-reference.md #5318

merged 17 commits into from
Apr 16, 2021

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Apr 14, 2021

What is changed, added or deleted? (Required)

Add tiup-dm-topology-reference.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 14, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 14, 2021

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/status PTAL
/translation from-docs-cn
/label require-LGT1
/cc @lucklove

@ti-chi-bot ti-chi-bot added status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Apr 14, 2021
@qiancai qiancai changed the title Add tiup-dm-topology-reference.md TiUP: Add tiup-dm-topology-reference.md Apr 14, 2021
@Joyinqin
Copy link
Contributor

/cc @ran-huang

tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved

The topology file of a DM cluster might contain the following blocks:

- [global](/tiup/tiup-dm-topology-reference.md#global): the global configuration of the cluster. Some of the configuration items use the default values on the cluster, and you can configure them separately in each instance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [global](/tiup/tiup-dm-topology-reference.md#global): the global configuration of the cluster. Some of the configuration items use the default values on the cluster, and you can configure them separately in each instance.
- [global](#global): the global configuration of the cluster. Some of the configuration items use the default values on the cluster, and you can configure them separately in each instance.

Self-referencing only needs an anchor name without a file name.

tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! These are just minor edits.

tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
qiancai and others added 2 commits April 16, 2021 11:22
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: SIGSEGV <gnu.crazier@gmail.com>
Co-authored-by: Allen Zhong <allen@moe.cat>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@lucklove
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2021
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM
A global comment: please limit the use of future tenses.

tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
tiup/tiup-dm-topology-reference.md Outdated Show resolved Hide resolved
Co-authored-by: Ran <huangran@pingcap.com>
@TomShawn
Copy link
Contributor

/lgtm
/label require-LGT1

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 494b022

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@ti-chi-bot ti-chi-bot merged commit c6aa3d2 into pingcap:master Apr 16, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5367

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5368

@TomShawn
Copy link
Contributor

/run-cherry-picker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants