-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TiUP: Add tiup-dm-topology-reference.md #5318
TiUP: Add tiup-dm-topology-reference.md #5318
Conversation
/label needs-cherry-pick-4.0 |
/cc @ran-huang |
tiup/tiup-dm-topology-reference.md
Outdated
|
||
The topology file of a DM cluster might contain the following blocks: | ||
|
||
- [global](/tiup/tiup-dm-topology-reference.md#global): the global configuration of the cluster. Some of the configuration items use the default values on the cluster, and you can configure them separately in each instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [global](/tiup/tiup-dm-topology-reference.md#global): the global configuration of the cluster. Some of the configuration items use the default values on the cluster, and you can configure them separately in each instance. | |
- [global](#global): the global configuration of the cluster. Some of the configuration items use the default values on the cluster, and you can configure them separately in each instance. |
Self-referencing only needs an anchor name without a file name.
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
…up-dm-topology-reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! These are just minor edits.
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: SIGSEGV <gnu.crazier@gmail.com> Co-authored-by: Allen Zhong <allen@moe.cat>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
…up-dm-topology-reference
…up-dm-topology-reference
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
A global comment: please limit the use of future tenses.
Co-authored-by: Ran <huangran@pingcap.com>
/lgtm |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 494b022
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #5367 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #5368 |
/run-cherry-picker |
What is changed, added or deleted? (Required)
Add tiup-dm-topology-reference.md
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?