Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update backup-and-restore-storages.md #5321

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Update backup-and-restore-storages.md #5321

merged 2 commits into from
Apr 20, 2021

Conversation

Joyinqin
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

使用 lightning 导入 s3 上的数据时，如果使用的是 endpoint 进行区分，需要进行 force-path-style 参数的设置。

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 14, 2021
@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 14, 2021
@Joyinqin
Copy link
Contributor Author

/cc @TomShawn @kennytm

@TomShawn
Copy link
Contributor

TomShawn commented Apr 14, 2021 •
edited
Loading

@Joyinqin Please add the version-specific label to the docs PR if the docs-cn PR has one.
Otherwise, we may make content errors on the release branch.

@Joyinqin
Copy link
Contributor Author

/label requires-version-specific-changes

@ti-chi-bot ti-chi-bot added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Apr 14, 2021
@Joyinqin
Copy link
Contributor Author

/label requires-version-specific-changes

@Joyinqin @TomShawn
Apply suggestions from code review
c16551c 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2021
@kennytm
Copy link
Contributor

kennytm commented Apr 20, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@kennytm: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 20, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c16551c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2021
@ti-chi-bot ti-chi-bot merged commit 639a0ce into pingcap:master Apr 20, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 20, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5321 to release-4.0
90221c4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5402

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 20, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5321 to release-5.0
697496b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5403

ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
Update backup-and-restore-storages.md (#5321) (#5403)
fab52aa
@Joyinqin Joyinqin deleted the br-patch-1 branch April 20, 2021 06:45
ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
Update backup-and-restore-storages.md (#5321) (#5402)
954b81b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@kennytm kennytm Awaiting requested review from kennytm

Assignees
No one assigned
Labels
requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Joyinqin @TomShawn @ti-chi-bot @kennytm @ti-srebot