Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: add TiUP DM introduction and docs for command dm-restart and dm-patch #5325

Merged
merged 9 commits into from
Apr 16, 2021
Merged

tiup: add TiUP DM introduction and docs for command dm-restart and dm-patch #5325

merged 9 commits into from
Apr 16, 2021

Conversation

CharLotteiu
Copy link
Contributor

What is changed, added or deleted? (Required)

Add 3 docs:

  • tiup/tiup-component-dm.md
  • tiup/tiup-component-dm-restart.md
  • tiup/tiup-component-dm-patch.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 14, 2021
@CharLotteiu
Copy link
Contributor Author

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 14, 2021
@CharLotteiu
Copy link
Contributor Author

Waiting for other tiup-component-dm-xx.md files to be merged to fix the dead links. This PR should be the last one to be merged.

@CharLotteiu
Copy link
Contributor Author

/sig tiup
/sig docs
/cc @lucklove @qiancai

@ti-chi-bot ti-chi-bot added area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. sig/docs Indicates that the Issue or PR belongs to the docs SIG. labels Apr 14, 2021
qiancai
qiancai reviewed Apr 15, 2021
View reviewed changes
tiup/tiup-component-dm.md Outdated Show resolved Hide resolved
tiup/tiup-component-dm.md Outdated Show resolved Hide resolved
tiup/tiup-component-dm-restart.md Outdated Show resolved Hide resolved
tiup/tiup-component-dm-restart.md Outdated Show resolved Hide resolved
tiup/tiup-component-dm-patch.md Outdated Show resolved Hide resolved
tiup/tiup-component-dm-patch.md Outdated Show resolved Hide resolved
tiup/tiup-component-dm-patch.md Outdated Show resolved Hide resolved
tiup/tiup-component-dm-patch.md Outdated Show resolved Hide resolved
tiup/tiup-component-dm-restart.md Outdated Show resolved Hide resolved
tiup/tiup-component-dm-restart.md Outdated Show resolved Hide resolved
CharLotteiu
CharLotteiu commented Apr 15, 2021
View reviewed changes
Copy link
Contributor Author

@CharLotteiu CharLotteiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change tiup cluster to tiup dm

tiup/tiup-component-dm-patch.md Outdated Show resolved Hide resolved
qiancai
qiancai reviewed Apr 15, 2021
View reviewed changes
tiup/tiup-component-dm-patch.md Outdated Show resolved Hide resolved
tiup/tiup-component-dm-patch.md Outdated Show resolved Hide resolved
tiup/tiup-component-dm-restart.md Outdated Show resolved Hide resolved
tiup/tiup-component-dm-restart.md Outdated Show resolved Hide resolved
lucklove
lucklove reviewed Apr 15, 2021
View reviewed changes
tiup/tiup-component-dm.md Outdated Show resolved Hide resolved
@lucklove
Copy link
Member

Rest LGTM

@qiancai
Copy link
Collaborator

qiancai commented Apr 16, 2021

/lgtm

@ti-chi-bot
Copy link
Member

@qiancai: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CharLotteiu
Copy link
Contributor Author

/rebase

CharLotteiu and others added 3 commits April 16, 2021 10:44
@CharLotteiu @Joyinqin
Update tiup/tiup-component-dm-restart.md
5302d39 
Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
@CharLotteiu
Update tiup/tiup-component-dm-patch.md
163a070
@CharLotteiu @AstroProfundis @lucklove
Apply suggestions from code review
8453c6d 
Co-authored-by: Allen Zhong <allen@moe.cat>
Co-authored-by: SIGSEGV <gnu.crazier@gmail.com>
@TomShawn
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2021
@TomShawn
Copy link
Contributor

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 16, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8453c6d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@ti-chi-bot ti-chi-bot merged commit 4abe9e6 into pingcap:master Apr 16, 2021
@TomShawn
Copy link
Contributor

/run-cherry-picker

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5325 to release-4.0
735c53e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5369

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5325 to release-5.0
9b30004 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5370

ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
tiup: add TiUP DM introduction and docs for command dm-restart and …
04535c0 
…`dm-patch` (#5325) (#5369)
ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
tiup: add TiUP DM introduction and docs for command dm-restart and …
c4e409a 
…`dm-patch` (#5325) (#5370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai left review comments

@Joyinqin Joyinqin Joyinqin left review comments

@lucklove lucklove lucklove left review comments

@AstroProfundis AstroProfundis AstroProfundis left review comments

Assignees
No one assigned
Labels
area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. require-LGT1 Indicates that the PR requires an LGTM. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@CharLotteiu @lucklove @qiancai @ti-chi-bot @TomShawn @ti-srebot @AstroProfundis @Joyinqin