Skip to content

tiup: align rest files in docs-cn#4868 #5331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2021
Merged

tiup: align rest files in docs-cn#4868 #5331

merged 3 commits into from
Apr 16, 2021

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Apr 15, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Align the files updated in pingcap/docs-cn#4868 (excluding new files)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2021
@TomShawn
Copy link
Contributor Author

TomShawn commented Apr 15, 2021

/cc @lucklove @AstroProfundis @ran-huang
/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation from-docs-cn
/status PTAL
/label require-LGT1

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. status/PTAL This PR is ready for reviewing. needs-cherry-pick-5.0 require-LGT1 Indicates that the PR requires an LGTM. and removed missing-translation-status This PR does not have translation status info. labels Apr 15, 2021
ran-huang
ran-huang reviewed Apr 15, 2021
View reviewed changes
ran-huang
ran-huang approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 15, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2021
@TomShawn
Copy link
Contributor Author

TomShawn commented Apr 16, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 16, 2021

This pull request has been accepted and is ready to merge.

Commit hash: 06f3926

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2021
@ti-chi-bot ti-chi-bot merged commit 0c93235 into pingcap:master Apr 16, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5331 to release-4.0
3837194 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Apr 16, 2021

cherry pick to release-4.0 in PR #5373

@TomShawn TomShawn deleted the ttiup-tocs-reste branch April 16, 2021 11:29
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 16, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5331 to release-5.0
235b433 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 16, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Apr 16, 2021

cherry pick to release-5.0 in PR #5374

ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
tiup: align rest files in docs-cn#4868 (#5331) (#5373)
785757c
ti-chi-bot pushed a commit that referenced this pull request Apr 16, 2021
@ti-srebot
tiup: align rest files in docs-cn#4868 (#5331) (#5374)
b9d26c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AstroProfundis AstroProfundis Awaiting requested review from AstroProfundis

@lucklove lucklove Awaiting requested review from lucklove

1 more reviewer

@ran-huang ran-huang ran-huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TomShawn @ti-chi-bot @ti-srebot @ran-huang