Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quick-start-with-tidb.md #5384

Merged
merged 5 commits into from
Apr 19, 2021
Merged

Update quick-start-with-tidb.md #5384

merged 5 commits into from
Apr 19, 2021

Conversation

Liuxiaozhen12
Copy link
Contributor

@Liuxiaozhen12 Liuxiaozhen12 commented Apr 19, 2021 •
edited
Loading

Add the Note translation

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Liuxiaozhen12
Update quick-start-with-tidb.md
97a49fc 
Add the Note translation
@CLAassistant
Copy link

CLAassistant commented Apr 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Apr 19, 2021
@ti-chi-bot
Copy link
Member

Welcome @Liuxiaozhen12!

It looks like this is your first PR to pingcap/docs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs. 😃

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2021
@TomShawn
Copy link
Contributor

/rebase

@Liuxiaozhen12 @TomShawn
Update quick-start-with-tidb.md
ecb148d 
Add the Note translation
TomShawn
TomShawn reviewed Apr 19, 2021
View reviewed changes
quick-start-with-tidb.md Outdated Show resolved Hide resolved
Liuxiaozhen12 and others added 2 commits April 19, 2021 13:55
Merge branch 'Liuxiaozhen12-patch-1' of https://github.com/Liuxiaozhe…
0415f14 
…n12/docs into Liuxiaozhen12-patch-1
@Liuxiaozhen12 @TomShawn
Update quick-start-with-tidb.md
0adfcf0 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
yikeke
yikeke reviewed Apr 19, 2021
View reviewed changes
quick-start-with-tidb.md Outdated Show resolved Hide resolved
@yikeke
Copy link
Contributor

yikeke commented Apr 19, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • yikeke

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2021
@yikeke yikeke added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Apr 19, 2021
@Liuxiaozhen12 @yikeke
Update quick-start-with-tidb.md
4dccc5d 
Co-authored-by: Coco Yee <40977455+yikeke@users.noreply.github.com>
@yikeke yikeke added needs-cherry-pick-4.0 require-LGT1 Indicates that the PR requires an LGTM. labels Apr 19, 2021
@yikeke
Copy link
Contributor

yikeke commented Apr 19, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4dccc5d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2021
@ti-chi-bot ti-chi-bot merged commit 0aeed0d into pingcap:master Apr 19, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 19, 2021
@Liuxiaozhen12 @ti-srebot
cherry pick pingcap#5384 to release-4.0
7a4d158 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 19, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5386

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 19, 2021
@Liuxiaozhen12 @ti-srebot
cherry pick pingcap#5384 to release-5.0
afd081c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 19, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5387

ti-chi-bot pushed a commit that referenced this pull request Apr 19, 2021
@ti-srebot
Update quick-start-with-tidb.md (#5384) (#5386)
df62106
ti-chi-bot pushed a commit that referenced this pull request Apr 19, 2021
@ti-srebot
Update quick-start-with-tidb.md (#5384) (#5387)
b1c77c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@yikeke yikeke yikeke left review comments

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Liuxiaozhen12 @CLAassistant @ti-chi-bot @TomShawn @yikeke @ti-srebot