Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the 5.0 branch info to CONTRIBUTING.md #5395

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Add the 5.0 branch info to CONTRIBUTING.md #5395

merged 1 commit into from
Apr 20, 2021

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Apr 20, 2021 •
edited by yikeke
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Add the info about the 5.0 branch to CONTRIBUTING.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 20, 2021
@qiancai
Copy link
Collaborator Author

qiancai commented Apr 20, 2021

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation no-need

@ti-chi-bot ti-chi-bot added translation/no-need No need to translate this PR. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 20, 2021
@qiancai qiancai changed the title Add the 5.0 branch to CONTRIBUTING.md Add the 5.0 branch info to CONTRIBUTING.md Apr 20, 2021
TomShawn
TomShawn approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2021
@TomShawn
Copy link
Contributor

@yikeke PTAL whether we need to update CONTRIBUTING.md of the 3.1/3.0/2.1 versions. Thanks~

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • yikeke

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 20, 2021
@yikeke
Copy link
Contributor

yikeke commented Apr 20, 2021

@yikeke PTAL whether we need to update CONTRIBUTING.md of the 3.1/3.0/2.1 versions. Thanks~

Yes please update them

@yikeke
Copy link
Contributor

yikeke commented Apr 20, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1067258

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 20, 2021
@ti-chi-bot ti-chi-bot merged commit e45daf5 into pingcap:master Apr 20, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 20, 2021
@qiancai @ti-srebot
cherry pick pingcap#5395 to release-2.1
f28697d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #5396

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 20, 2021
@qiancai @ti-srebot
cherry pick pingcap#5395 to release-3.0
7519a80 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #5397

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 20, 2021
@qiancai @ti-srebot
cherry pick pingcap#5395 to release-3.1
25d8136 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #5398

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 20, 2021
@qiancai @ti-srebot
cherry pick pingcap#5395 to release-4.0
53d829b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5399

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 20, 2021
@qiancai @ti-srebot
cherry pick pingcap#5395 to release-5.0
be13dca 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 20, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5400

ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
Add the 5.0 branch info to CONTRIBUTING.md (#5395) (#5399)
1c73f25
ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
Add the 5.0 branch info to CONTRIBUTING.md (#5395) (#5400)
5bf240b
ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
Add the 5.0 branch info to CONTRIBUTING.md (#5395) (#5398)
6103ccb
ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
Add the 5.0 branch info to CONTRIBUTING.md (#5395) (#5396)
6b785d8
ti-chi-bot pushed a commit that referenced this pull request Apr 20, 2021
@ti-srebot
Add the 5.0 branch info to CONTRIBUTING.md (#5395) (#5397)
d90b190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@yikeke yikeke yikeke approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qiancai @TomShawn @ti-chi-bot @yikeke @ti-srebot