Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a missing F1 mention in docs #5423

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Remove a missing F1 mention in docs #5423

merged 2 commits into from
Apr 22, 2021

Conversation

TomShawn
Copy link
Contributor

What is changed, added or deleted? (Required)

Remove a missing F1 mention in docs

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2021
@TomShawn TomShawn mentioned this pull request Apr 21, 2021
Merged
10 tasks
@TomShawn
Copy link
Contributor Author

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation done
/assign
/cc @CharLotteiu

@ti-chi-bot ti-chi-bot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Apr 21, 2021
@ti-chi-bot ti-chi-bot added needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 21, 2021
This was referenced Apr 21, 2021
Merged
Merged
CharLotteiu
CharLotteiu reviewed Apr 21, 2021
View reviewed changes
tidb-computing.md Outdated Show resolved Hide resolved
@TomShawn @CharLotteiu
Update tidb-computing.md
8816f8d 
Co-authored-by: Charlotte Liu <37295236+CharLotteiu@users.noreply.github.com>
CharLotteiu
CharLotteiu approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@CharLotteiu CharLotteiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharLotteiu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 21, 2021
@TomShawn
Copy link
Contributor Author

/label require-LGT1

@ti-chi-bot ti-chi-bot added the require-LGT1 Indicates that the PR requires an LGTM. label Apr 22, 2021
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8816f8d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2021
@ti-chi-bot ti-chi-bot merged commit d906e69 into pingcap:master Apr 22, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 22, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5423 to release-4.0
332f210 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 22, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5431

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 22, 2021
@TomShawn @ti-srebot
cherry pick pingcap#5423 to release-5.0
51696ea 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 22, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5432

@TomShawn TomShawn deleted the patch-1 branch April 22, 2021 03:27
ti-chi-bot pushed a commit that referenced this pull request Apr 22, 2021
@ti-srebot
Remove a missing F1 mention in docs (#5423) (#5432)
e8071e6
ti-chi-bot pushed a commit that referenced this pull request Apr 22, 2021
@ti-srebot
Remove a missing F1 mention in docs (#5423) (#5431)
af61550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharLotteiu CharLotteiu CharLotteiu approved these changes

Assignees

@TomShawn TomShawn

Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomShawn @ti-chi-bot @ti-srebot @CharLotteiu