Skip to content

Batch add anchor links in TiUP command docs #5593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 12, 2021
Merged

Batch add anchor links in TiUP command docs #5593

merged 4 commits into from
May 12, 2021

Conversation

@Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented May 10, 2021 •
edited by TomShawn
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

To avoid the orphan pages of TiUP docs in the en website and optimize user experience, batch add anchor links in specific command docs.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 10, 2021 03:34
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2021
@Joyinqin Joyinqin changed the title Batch adds TiUP docs links Batch add anchor links in TiUP command docs May 10, 2021
@Joyinqin
Copy link
Contributor Author

Joyinqin commented May 10, 2021

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation no-need

@ti-chi-bot ti-chi-bot added translation/no-need No need to translate this PR. needs-cherry-pick-5.0 and removed missing-translation-status This PR does not have translation status info. labels May 10, 2021
@TomShawn TomShawn added translation/doing This PR's assignee is translating this PR. and removed translation/no-need No need to translate this PR. labels May 10, 2021
@Joyinqin
Copy link
Contributor Author

Joyinqin commented May 10, 2021

/cc @lucklove

@ti-chi-bot ti-chi-bot requested a review from lucklove May 10, 2021 03:47
TomShawn
TomShawn approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 11, 2021
@TomShawn
Copy link
Contributor

TomShawn commented May 12, 2021

@lucklove Would you help take a look and see if this PR can be merged? Thanks!

@Joyinqin Joyinqin mentioned this pull request May 12, 2021
Merged
11 tasks
@TomShawn TomShawn linked an issue May 12, 2021 that may be closed by this pull request
Orphaned tiup documentation pages #5317
Closed
@Joyinqin
Copy link
Contributor Author

Joyinqin commented May 12, 2021

/translation done
/remove-translation doing

@ti-chi-bot ti-chi-bot added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels May 12, 2021
@lucklove
Copy link
Member

lucklove commented May 12, 2021

/lgtm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • lucklove

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 12, 2021
@TomShawn TomShawn merged commit 796b28f into pingcap:master May 12, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request May 12, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5593 to release-4.0
7988eaf 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 12, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented May 12, 2021

cherry pick to release-4.0 in PR #5611

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request May 12, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5593 to release-5.0
22999d6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request May 12, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented May 12, 2021

cherry pick to release-5.0 in PR #5612

ti-chi-bot pushed a commit that referenced this pull request May 12, 2021
@ti-srebot
Batch add anchor links in TiUP command docs (#5593) (#5611)
1d7bb57
TomShawn pushed a commit that referenced this pull request May 12, 2021
@ti-srebot @Joyinqin
cherry pick #5593 to release-5.0 (#5612)
f9e966f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
@Joyinqin Joyinqin deleted the links-patch branch May 12, 2021 09:03
This was referenced May 12, 2021
Merged
Merged
@ti-chi-bot ti-chi-bot mentioned this pull request May 12, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucklove lucklove Awaiting requested review from lucklove

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Joyinqin Joyinqin

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Orphaned tiup documentation pages

5 participants

@Joyinqin @TomShawn @lucklove @ti-chi-bot @ti-srebot