Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system-variables: update permitted ranges #6665

Merged
merged 1 commit into from
Nov 1, 2021
Merged

system-variables: update permitted ranges #6665

merged 1 commit into from
Nov 1, 2021

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Oct 25, 2021

What is changed, added or deleted? (Required)

This is auto generated from the server code.

It updates the permitted ranges of values following the merge of pingcap/tidb#28842

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@morgo morgo requested review from dveeden and TomShawn October 25, 2021 00:53
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 25, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • dveeden

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2021
@shichun-0415 shichun-0415 added sig/docs Indicates that the Issue or PR belongs to the docs SIG. area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. translation/doing This PR's assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. and removed missing-translation-status This PR does not have translation status info. labels Oct 25, 2021
@shichun-0415 shichun-0415 self-assigned this Oct 25, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 25, 2021
@ti-chi-bot
Copy link
Member

@bb7133: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bb7133
Copy link
Member

bb7133 commented Oct 25, 2021

LGTM

TomShawn
TomShawn approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 1, 2021
@TomShawn TomShawn added type/bugfix This PR fixes a bug. and removed type/enhancement The issue or PR belongs to an enhancement. labels Nov 1, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Nov 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 79b5d1d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 1, 2021
@TomShawn TomShawn added the priority/P1 The issue has P1 priority. label Nov 1, 2021
@ti-chi-bot ti-chi-bot merged commit 966c86d into pingcap:master Nov 1, 2021
@shichun-0415 shichun-0415 mentioned this pull request Nov 1, 2021
Merged
13 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Nov 1, 2021
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 1, 2021
@morgo @ti-chi-bot
This is an automated cherry-pick of pingcap#6665
a585eab 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 1, 2021
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6700.

@morgo morgo mentioned this pull request Nov 17, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@dveeden dveeden dveeden approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees

@shichun-0415 shichun-0415

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. sig/docs Indicates that the Issue or PR belongs to the docs SIG. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@morgo @ti-chi-bot @bb7133 @TomShawn @dveeden @shichun-0415