Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docs for GET_LOCK #8440

Merged
merged 10 commits into from
May 20, 2022
Merged

add docs for GET_LOCK #8440

merged 10 commits into from
May 20, 2022

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Apr 29, 2022

What is changed, added or deleted? (Required)

This updates the docs for GET_LOCK, RELEASE_LOCK, RELEASE_ALL_LOCKS. A feature I worked on for TiDB 6.1.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

pingcap/tidb#33947

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 29, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • dveeden

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 29, 2022
@morgo morgo requested review from mjonss and dveeden April 29, 2022 15:55
@TomShawn TomShawn added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. v6.1 This PR/issue applies to TiDB v6.1. labels Apr 30, 2022
@TomShawn TomShawn self-assigned this Apr 30, 2022
@TomShawn TomShawn added translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Apr 30, 2022
functions-and-operators/locking-functions.md Show resolved Hide resolved
functions-and-operators/locking-functions.md Outdated Show resolved Hide resolved
functions-and-operators/locking-functions.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 2, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 9, 2022
@morgo
Copy link
Contributor Author

morgo commented May 9, 2022

@dveeden @seiya-annie PTAL again. Thanks!

Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly minor comments

functions-and-operators/locking-functions.md Outdated Show resolved Hide resolved
functions-and-operators/locking-functions.md Outdated Show resolved Hide resolved
functions-and-operators/locking-functions.md Outdated Show resolved Hide resolved
functions-and-operators/locking-functions.md Outdated Show resolved Hide resolved
functions-and-operators/locking-functions.md Outdated Show resolved Hide resolved
functions-and-operators/locking-functions.md Outdated Show resolved Hide resolved
morgo and others added 5 commits May 13, 2022 07:15
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor suggestions and questions.

functions-and-operators/locking-functions.md Outdated Show resolved Hide resolved
functions-and-operators/locking-functions.md Outdated Show resolved Hide resolved
functions-and-operators/locking-functions.md Outdated Show resolved Hide resolved
Co-authored-by: Mattias Jonsson <mjonss@users.noreply.github.com>
Co-authored-by: Mattias Jonsson <mjonss@users.noreply.github.com>
@TomShawn TomShawn requested a review from seiya-annie May 16, 2022 08:50
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 19, 2022
@TomShawn TomShawn requested a review from mjonss May 19, 2022 03:32
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a9f15c8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 20, 2022
@TomShawn TomShawn merged commit cbeb9cd into pingcap:master May 20, 2022
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.1 This PR/issue applies to TiDB v6.1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants