Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ticdc: add ticdc-avro-protocol.md #8740

Merged
merged 11 commits into from
Jun 2, 2022
Merged

ticdc: add ticdc-avro-protocol.md #8740

merged 11 commits into from
Jun 2, 2022

Conversation

shichun-0415
Copy link
Contributor

@shichun-0415 shichun-0415 commented May 25, 2022 •
edited by zhangyangyu
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.1 (TiDB 6.1 versions)
  • v6.0 (TiDB 6.0 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn May 25, 2022 12:14
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 25, 2022
@shichun-0415 shichun-0415 added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.0 This PR/issue applies to TiDB v6.0. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. v6.1 This PR/issue applies to TiDB v6.1. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. missing-translation-status This PR does not have translation status info. labels May 25, 2022
@shichun-0415 shichun-0415 requested review from qiancai and zhangyangyu and removed request for TomShawn May 25, 2022 12:14
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 25, 2022
@shichun-0415 shichun-0415 removed the v6.0 This PR/issue applies to TiDB v6.0. label May 25, 2022
@zhangyangyu zhangyangyu mentioned this pull request May 27, 2022
Closed
qiancai
qiancai reviewed Jun 1, 2022
View reviewed changes
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
@zhangyangyu @qiancai
Apply suggestions from code review
1154a31 
Co-authored-by: Grace Cai <qqzczy@126.com>
@zhangyangyu
Copy link
Member

Nice catch! @qiancai

qiancai
qiancai reviewed Jun 2, 2022
View reviewed changes
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
ticdc/ticdc-avro-protocol.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2022
@zhangyangyu @qiancai
Apply suggestions from code review
bd485cb 
Co-authored-by: Grace Cai <qqzczy@126.com>
@shichun-0415
Copy link
Contributor Author

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 2, 2022
@shichun-0415
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bd485cb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2022
@ti-chi-bot ti-chi-bot merged commit 82ad607 into pingcap:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@zhangyangyu zhangyangyu zhangyangyu approved these changes

Assignees
No one assigned
Labels
area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v6.1 This PR/issue applies to TiDB v6.1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shichun-0415 @ti-chi-bot @zhangyangyu @qiancai