Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

dumpling v5.+ may dump partitioned tables incorrectly because the result of tablesample is inordered #334

Closed
lichunzhu opened this issue Aug 19, 2021 · 4 comments · May be fixed by #350
Closed

dumpling v5.+ may dump partitioned tables incorrectly because the result of tablesample is inordered #334

lichunzhu opened this issue Aug 19, 2021 · 4 comments · May be fixed by #350
Labels
severity/major This issue is a major bug type/bug This issue is a bug

Comments

@lichunzhu
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.

More details see pingcap/tidb#27349

  1. What did you expect to see?

Dumpling dump data correctly.

  1. What did you see instead?

Some data are lost and some are duplicated.

  1. Versions of the cluster

    • Dumpling version (run dumpling -V):

      All v5.0.+, v5.1.+, v5.2.+

    • Source database version (execute SELECT version(); in a MySQL client):

      All v5.0.+, v5.1.+, v5.2.+
@lichunzhu
Copy link
Contributor Author

We can sort pkVals by ourselves to avoid this problem.

dumpling/v4/export/dump.go

Line 726 in 4e012e5

return pkFields, pkVals, iter.Error()

@fubinzh
Copy link

fubinzh commented Aug 25, 2021

/type bug

@ti-chi-bot ti-chi-bot added the type/bug This issue is a bug label Aug 25, 2021
@fubinzh
Copy link

fubinzh commented Aug 25, 2021

/severity major

@ti-chi-bot ti-chi-bot added the severity/major This issue is a major bug label Aug 25, 2021
@lichunzhu lichunzhu linked a pull request Sep 2, 2021 that will close this issue
add a func for sort pkVals #350
Open
@lichunzhu lichunzhu mentioned this issue Sep 2, 2021
Open
@lichunzhu
Copy link
Contributor Author

TiDB has already fixed this bug. We'd better ask users to upgrade to newer TiDB to avoid this bug. Close this issue now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
severity/major This issue is a major bug type/bug This issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add a func for sort pkVals
3 participants
@fubinzh @lichunzhu @ti-chi-bot