Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

add a func for sort pkVals #350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add a func for sort pkVals #350

wants to merge 1 commit into from

Conversation

docsir
Copy link
Contributor

@docsir docsir commented Sep 2, 2021

fix #334
For dump.go,I have added a func for sort pkVals.

This change will make sure us to see dumpling dump data correctly.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Sep 2, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link
Member

Welcome @docsir!

It looks like this is your first PR to pingcap/dumpling 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/dumpling. 😃

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't use string to save and sort all the values.
For integer values we may get "115 < 12" if we sort in this way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dumpling v5.+ may dump partitioned tables incorrectly because the result of tablesample is inordered
4 participants