support --max-idle-time argument #326
Conversation
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
|
|
Welcome @dba-kit! |
|
@dba-kit Could you please help sign the CLA? |
|
this commit de1f43d is associated with another email rather than your GitHub account. You can change commit email address and fix this problem (maybe file another PR). |
done, but I find I delete a line in |
| @@ -242,7 +244,7 @@ func (conf *Config) DefineFlags(flags *pflag.FlagSet) { | |||
| flags.StringToString(flagParams, nil, `Extra session variables used while dumping, accepted format: --params "character_set_client=latin1,character_set_connection=latin1"`) | |||
| flags.Bool(FlagHelp, false, "Print help message and quit") | |||
| flags.Duration(flagReadTimeout, 15*time.Minute, "I/O read timeout for db connection.") | |||
| _ = flags.MarkHidden(flagReadTimeout) | |||
| flags.Duration(flagMaxIdleTime, 600*time.Second, "max idle time for db connection.") | |||
There was a problem hiding this comment.
We'd better keep flagReadTimeout hidden. What's more, we'd better keep flagMaxIdleTime hidden, too. We can "un-hidden" these arguments if they are frequently used.
There was a problem hiding this comment.
err... so those arguments still unseen to others, unless they look the source code?
There was a problem hiding this comment.
We can add these flags to official documents.
lichunzhu
added
the
needs-cherry-pick-release-5.2
|
@dba-kit hello, Dumpling has been moved to https://github.com/pingcap/tidb/tree/master/dumpling now. Could you please help move this PR to pingcap/tidb? |
See #282