debugpb: support fail point #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
overvenus
commented
Sep 27, 2017
proto/debugpb.proto
Outdated
| @@ -99,3 +103,22 @@ message ScanMvccResponse { | |||
| bytes key = 1; | |||
| kvrpcpb.MvccInfo info = 2; | |||
| } | |||
|
|
|||
| message Failure { | |||
| enum Type { | |||
There was a problem hiding this comment.
Maybe we should figure out a better name.
There was a problem hiding this comment.
Add two methods instead, one for setting and one for removal.
overvenus
commented
Sep 27, 2017
proto/debugpb.proto
Outdated
| message Failure { | ||
| enum Type { | ||
| INVALID = 0; | ||
| INJECT = 1; |
There was a problem hiding this comment.
Should we remove INVALID and set INJECT as default?
overvenus
commented
Sep 27, 2017
proto/debugpb.proto
Outdated
| } | ||
|
|
||
| message FailPointRequest { | ||
| repeated Failure failures = 1; |
There was a problem hiding this comment.
Should it be one request for one failure?
Let's consider failures [A, B, C], we may set A and B successfully but C failed, so what should we do? Revert A and B then return error to client? But it is possible that A or B is already be triggered.
|
PTAL @BusyJay |
BusyJay
reviewed
Sep 29, 2017
proto/debugpb.proto
Outdated
| @@ -38,6 +38,10 @@ service Debug { | |||
| // Note: DO NOT CALL IT IN PRODUCTION, it's really expensive. | |||
| // Server uses keys directly w/o any encoding. | |||
| rpc ScanMvcc(ScanMvccRequest) returns (stream ScanMvccResponse) {} | |||
|
|
|||
| // Inject fail points. Currently, it only used in tests. | |||
proto/debugpb.proto
Outdated
| } | ||
|
|
||
| message FailPointRequest { | ||
| repeated Failure failures = 1; |
proto/debugpb.proto
Outdated
| @@ -99,3 +103,22 @@ message ScanMvccResponse { | |||
| bytes key = 1; | |||
| kvrpcpb.MvccInfo info = 2; | |||
| } | |||
|
|
|||
| message Failure { | |||
| enum Type { | |||
There was a problem hiding this comment.
Add two methods instead, one for setting and one for removal.
|
PTAL |
|
LGTM |
|
|
|
LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail point API for injecting failures!