Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvrpcpb: record rollback reason in the CheckTxnStatus response #491

Merged
merged 3 commits into from
Nov 13, 2019

Conversation

tiancaiamao
Copy link
Contributor

When the CheckTxnStatus returns rollbacked, provide the rollback reason.

We need this information to debug pingcap/tidb#13397

@coocood @youjiali1995 @MyonKeminta

proto/kvrpcpb.proto Outdated Show resolved Hide resolved
@coocood
Copy link
Member

coocood commented Nov 13, 2019

LGTM

coocood
coocood previously approved these changes Nov 13, 2019
Copy link
Contributor

@youjiali1995 youjiali1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood merged commit 45e0702 into master Nov 13, 2019
@coocood coocood deleted the rollback-reason branch November 13, 2019 11:51
daimashusheng pushed a commit to daimashusheng/kvproto that referenced this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants