keyspacepb #952
Merged
keyspacepb #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
11 tasks
ystaticy
reviewed
Jul 13, 2022
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
ystaticy
reviewed
Jul 20, 2022
Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
disksing
reviewed
Jul 28, 2022
| option java_package = "org.tikv.kvproto"; | ||
|
|
||
| // Keyspace provides services to manage keyspaces. | ||
| service Keyspace { |
There was a problem hiding this comment.
It seems that service is readonly. I wonder how can we create/update/delete keyspaces?
There was a problem hiding this comment.
Create/ UpdateState/ UpdateConfig can be done through HTTP API.
There was a problem hiding this comment.
the client should create a keyspace via HTTP?
There was a problem hiding this comment.
Target Keyspace should exist prior to client's connection.
A default keyspace with name "DEFAULT" and id 0 is created when KeyspaceManager initialize, if a client (with keyspace enabled) does not provide a keyspace name, if will connect to default keyspace.
AndreMouche
reviewed
Aug 2, 2022
| KeyspaceMeta keyspace = 2; | ||
| } | ||
|
|
||
| message WatchKeyspacesRequest { |
There was a problem hiding this comment.
Why we need to watch all key-spaces?
|
/merge |
|
/merge |
iosmanthus
pushed a commit
to iosmanthus/kvproto
that referenced
this pull request
Oct 1, 2022
* added keyspacepb Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
iosmanthus
pushed a commit
to iosmanthus/kvproto
that referenced
this pull request
Oct 1, 2022
* added keyspacepb Signed-off-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref issue: tikv/pd#5293