*: supports Unifiled Log Format #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolouch
force-pushed
the
log-format
branch
2 times, most recently
from
d73696a to
b03a209
Compare
Signed-off-by: nolouch <nolouch@gmail.com>
rleungx
reviewed
Jan 25, 2019
| // initFileLog initializes file based logging options. | ||
| func initFileLog(cfg *FileLogConfig) (*lumberjack.Logger, error) { | ||
| if st, err := os.Stat(cfg.Filename); err == nil { | ||
| if st.IsDir() { |
There was a problem hiding this comment.
Do we need to check if the file has already existed or it is writable?
There was a problem hiding this comment.
I think it will processed by lumberjack.
Signed-off-by: nolouch <nolouch@gmail.com>
breezewish
approved these changes
Jan 28, 2019
| Get = _pool.Get | ||
| ) | ||
|
|
||
| func getTextEncoder() *textEncoder { |
There was a problem hiding this comment.
why do we need a pool for the encoder?
There was a problem hiding this comment.
Sometimes we need cloned to create a temp encoder, so use a pool to reduce allocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nolouch nolouch@gmail.com
supports Unified Log Format