output the internal errors of zap logger to stderr #24
Conversation
|
/cc @nolouch |
|
How do you capture the error when your program running in background, and terminal is closed? |
@nolouch For this question, we can redirect the stderr of a process (like cdc server) to a different file in another disk partition. Moreover, for a daemon process which is suspected of running abnormally, users usually can do troubleshooting as follows:
In brief, i think it's better to write the internal error of zap logger to stderr, and leave it to the user of pingcap/log lib to determine whether to redirect stderr to a different file or run the process manually. |
…he internal zap logger error
config.go
Outdated
| // ErrorOutputPath is a path to write internal logger errors to. | ||
| // If this field is not set, the internal logger errors will be sent to the same file as in File field. | ||
| // Note: if we want to output the logger errors to stderr, we can just set this field to "stderr" | ||
| ErrorOutputPath string |
There was a problem hiding this comment.
I think you should provide the toml and json tag?
Solve the problem in cdc issue 3362 .
At present, when we write log messages to a log file which resides in a full disk, pingcap/log just silently discard the i/o error "no space left on device". As a result, users can not conveniently identify the root cause.
Similarly, when other internal errors happen in zap logger, we should output them to stderr as soon as possible.