Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the LogRotate field #8

Merged
merged 1 commit into from
Oct 12, 2019
Merged

remove the LogRotate field #8

merged 1 commit into from
Oct 12, 2019

Conversation

tiancaiamao
Copy link
Contributor

Nobody is using it, change this config doesn't take effect.
It makes people confusing.

@nolouch

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch nolouch merged commit b742a5d into master Oct 12, 2019
@tisonkun tisonkun deleted the remove-rotate branch August 18, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants