Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support global kill #1022

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

support global kill #1022

wants to merge 2 commits into from

Conversation

pingyu
Copy link
Contributor

@pingyu pingyu commented Sep 13, 2020 •
edited by SunRunAway
Loading

What problem does this PR solve?

Issue Number: pingcap/tidb#8854

Problem Summary:
Support CTRL-C or KILL to kill a connection/query.

What is changed and how it works?

Compose a global unique connection id by a unique server id and local unique connection id. See design doc and pingcap/tidb#17649 for detail.

This PR fix comment of TiDBExtension for consistence.

Check List

Tests

  • No code

@pingyu
Copy link
Contributor Author

pingyu commented Sep 13, 2020

/rebuild

SunRunAway
SunRunAway reviewed Sep 14, 2020
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@SunRunAway,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: ddl(slack).

breezewish
breezewish approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@breezewish breezewish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is it better to just remove this field TiDBExtension? (Parser generates the same AST for both KILL and KILL TIDB)

@ti-srebot
Copy link
Contributor

@breeswish, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: ddl(slack).

1 similar comment
@ti-srebot
Copy link
Contributor

@breeswish, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: ddl(slack).

kennytm
kennytm approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGT1 label Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@breezewish breezewish breezewish approved these changes

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
contribution status/LGT1 LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pingyu @ti-srebot @kennytm @SunRunAway @breezewish