Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: implement Restore for TableToTable #109

Merged
merged 6 commits into from
Dec 25, 2018
Merged

parser: implement Restore for TableToTable #109

merged 6 commits into from
Dec 25, 2018

Conversation

tony612
Copy link
Contributor

@tony612 tony612 commented Dec 22, 2018

kennytm
kennytm reviewed Dec 22, 2018
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Dec 22, 2018
@zier-one zier-one mentioned this pull request Dec 23, 2018
Closed
zier-one
zier-one previously approved these changes Dec 24, 2018
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one
Copy link
Contributor

zier-one commented Dec 24, 2018 •
edited
Loading

resolve conflicts please @tony612
and fix ci please

@zier-one zier-one added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Dec 24, 2018
@zier-one zier-one mentioned this pull request Dec 24, 2018
Merged
@zier-one
Copy link
Contributor

run gofmt -s -l -w .

@kennytm kennytm added the DNM label Dec 24, 2018
@zier-one zier-one merged commit 23d94c2 into pingcap:master Dec 25, 2018
@zier-one zier-one removed the DNM label Jan 4, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@tony612
parser: implement Restore for TableToTable (pingcap#109)
885aa20
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@tony612
parser: implement Restore for TableToTable (pingcap#109)
cff516e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@zier-one zier-one zier-one approved these changes

Assignees
No one assigned
Labels
contribution status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tony612 @zier-one @kennytm