Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser.y: populate the Fields field for TABLE and VALUES statements #1118

Merged
merged 1 commit into from
Dec 8, 2020
Merged

parser.y: populate the Fields field for TABLE and VALUES statements #1118

merged 1 commit into from
Dec 8, 2020

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Dec 3, 2020

What problem does this PR solve?

pingcap/tidb#21486.

What is changed and how it works?

Initialize the SelectStmt.Fields fields with * so TiDB code using sel.Fields.Fields won't panic.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • TABLE t works after using the new parser.

Code changes

Side effects

Related changes

@kennytm kennytm mentioned this pull request Dec 3, 2020
Closed
@kennytm kennytm requested a review from tangenta December 4, 2020 10:23
tangenta
tangenta reviewed Dec 7, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGT1 label Dec 7, 2020
@coocood
Copy link
Member

coocood commented Dec 8, 2020

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGT1 label Dec 8, 2020
@ti-srebot ti-srebot added the status/LGT2 LGT2 label Dec 8, 2020
@kennytm kennytm removed the request for review from wjhuang2016 December 8, 2020 08:45
@kennytm kennytm merged commit 88851d9 into master Dec 8, 2020
@kennytm kennytm deleted the kennytm/populate-fields-for-table-and-values branch December 8, 2020 08:45
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@kennytm
parser.y: populate the Fields field for TABLE and VALUES statements (p…
a14b631 
…ingcap#1118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@coocood coocood Awaiting requested review from coocood

Assignees
No one assigned
Labels
status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennytm @coocood @tangenta @ti-srebot