ast, parser: add FUNCTION and PROCEDURE for GRANT object_type #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance6716
commented
Dec 22, 2020
| @@ -11774,13 +11776,22 @@ PrivType: | |||
| } | |||
|
|
|||
| ObjectType: | |||
| %prec lowerThanFunction | |||
There was a problem hiding this comment.
function is not a reserved keywork in 5.7 (but become reserved after 8.0.1). see https://dev.mysql.com/doc/refman/8.0/en/keywords.html#keywords-8-0-detailed-F
here I didn't change it to reserved to keep compatibility
|
PTAL @wjhuang2016 @leoppro @xhebox |
ti-srebot
approved these changes
Dec 22, 2020
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
parser didn't support
GRANT ... ON FUNCTION ..., where DM plans to parse and check privileges in pingcap/dm#1320ref https://dev.mysql.com/doc/refman/5.7/en/grant.html
What is changed and how it works?
add
ObjectTypeFunctionandObjectTypeProcedureCheck List
Tests
Code changes
Side effects
Related changes