Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: implement Restore for OnCondition and TableRefsClause #132

Merged
merged 3 commits into from
Dec 28, 2018
Merged

parser: implement Restore for OnCondition and TableRefsClause #132

merged 3 commits into from
Dec 28, 2018

Conversation

exialin
Copy link
Contributor

@exialin exialin commented Dec 27, 2018 •
edited
Loading

Implement Restore and unit test for OnCondition and TableRefsClause. Fix Restore of Join.

Issue: pingcap/tidb#8532

@zier-one zier-one mentioned this pull request Dec 27, 2018
Closed
kennytm
kennytm reviewed Dec 27, 2018
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Dec 27, 2018
@exialin exialin changed the title parser: implement Restore for OnCondition parser: implement Restore for OnCondition and TableRefsClause Dec 27, 2018
@exialin
Copy link
Contributor Author

exialin commented Dec 27, 2018

@kennytm Sorry I added Restore of TableRefsClause, which can be combined in this PR.

@kennytm kennytm removed the status/LGT1 LGT1 label Dec 27, 2018
kennytm
kennytm reviewed Dec 27, 2018
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Dec 27, 2018
@zier-one zier-one added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Dec 28, 2018
zier-one
zier-one approved these changes Dec 28, 2018
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one merged commit a4bdcab into pingcap:master Dec 28, 2018
@exialin exialin deleted the restore-on branch December 28, 2018 04:03
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@exialin
parser: implement Restore for OnCondition and TableRefsClause (pingca…
6db9ecb 
…p#132)
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@exialin
parser: implement Restore for OnCondition and TableRefsClause (pingca…
3a0476b 
…p#132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@zier-one zier-one zier-one approved these changes

Assignees
No one assigned
Labels
contribution status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@exialin @kennytm @zier-one