*: add ActionModifyTableCharsetAndCollate to support alter table charset and collate #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er into support_alter_table_charset
tiancaiamao
reviewed
Dec 5, 2018
ast/ddl.go
Outdated
| @@ -821,6 +821,8 @@ type TableOption struct { | |||
| Tp TableOptionType | |||
| StrValue string | |||
| UintValue uint64 | |||
| // Skipped indicate the TableOption can be skipped. | |||
| Skipped bool | |||
There was a problem hiding this comment.
I think this field is confusing, it's not something belong to TableOption
crazycs520
reviewed
Dec 10, 2018
| ActionAddTablePartition ActionType = 19 | ||
| ActionDropTablePartition ActionType = 20 | ||
| ActionCreateView ActionType = 21 | ||
| ActionModifyTableCharsetAndCollate ActionType = 22 |
There was a problem hiding this comment.
Need change var actionMap = map[ActionType]string ?
…er into support_alter_table_charset
crazycs520
pushed a commit
to crazycs520/parser
that referenced
this pull request
Jan 5, 2019
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for pingcap/tidb#8037