Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: support show create database if not exists syntax #148

Merged
merged 1 commit into from
Jan 3, 2019
Merged

parser: support show create database if not exists syntax #148

merged 1 commit into from
Jan 3, 2019

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Jan 3, 2019

@lonng lonng added the type/enhancement New feature or request label Jan 3, 2019
@lonng
Copy link
Contributor Author

lonng commented Jan 3, 2019

/run-all-tests

@lonng lonng requested review from tiancaiamao and zier-one and removed request for tiancaiamao January 3, 2019 09:27
winkyao
winkyao reviewed Jan 3, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao
Copy link
Contributor

winkyao commented Jan 3, 2019

@crazycs520 PTAL

@lonng lonng mentioned this pull request Jan 3, 2019
Merged
@kennytm kennytm added the status/LGT1 LGT1 label Jan 3, 2019
crazycs520
crazycs520 approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Jan 3, 2019
@lonng lonng merged commit 5d5a6dd into pingcap:master Jan 3, 2019
lonng added a commit to pingcap/tidb that referenced this pull request Jan 4, 2019
@lonng
planner,executor: support show create database if not exists syntax (…
e0b30fe 
…#8926)

<!--
Thank you for contributing to TiDB! Please read TiDB's [CONTRIBUTING](https://github.com/pingcap/tidb/blob/master/CONTRIBUTING.md) document **BEFORE** filing this PR.
-->

### What problem does this PR solve? <!--add issue link with summary if exists-->

pingcap/parser#147
pingcap/parser#148

MySQL compatibility: `show create database if not exists` syntax

See: https://dev.mysql.com/doc/refman/5.7/en/show-create-database.html

MySQL

```
MariaDB [(none)]> show create database b2;
+----------+----------------------------------------------------------------+
| Database | Create Database                                                |
+----------+----------------------------------------------------------------+
| b2       | CREATE DATABASE `b2` /*!40100 DEFAULT CHARACTER SET utf8mb4 */ |
+----------+----------------------------------------------------------------+
1 row in set (0.002 sec)

MariaDB [(none)]> show create database if not exists b2;
+----------+-----------------------------------------------------------------------------------------+
| Database | Create Database                                                                         |
+----------+-----------------------------------------------------------------------------------------+
| b2       | CREATE DATABASE /*!32312 IF NOT EXISTS*/ `b2` /*!40100 DEFAULT CHARACTER SET utf8mb4 */ |
+----------+-----------------------------------------------------------------------------------------+
1 row in set (0.000 sec)
```

TiDB
```
MySQL [b1]> show create batabase b2;
ERROR 1105 (HY000): line 1 column 20 near " b2" (total length 23)
MySQL [b1]> show create database b2;
+----------+-----------------------------------------------------------------+
| Database | Create Database                                                 |
+----------+-----------------------------------------------------------------+
| b2       | CREATE DATABASE `b2` /* !40100 DEFAULT CHARACTER SET utf8mb4 */ |
+----------+-----------------------------------------------------------------+
1 row in set (0.000 sec)

MySQL [b1]> show create database if not exists b2;
ERROR 1105 (HY000): line 1 column 23 near " not exists b2" (total length 37)
```

### What is changed and how it works?

Insert `/*!32312 IF NOT EXISTS*/` before shema name when statement contains `if not exists`

### Check List <!--REMOVE the items that are not applicable-->

Tests <!-- At least one of them must be included. -->

 - Unit test

Code changes

Side effects

Related changes

 - Need to cherry-pick to the release branch

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/pingcap/tidb/8926)
<!-- Reviewable:end -->
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@lonng
parser: support show create database if not exists syntax (pingcap#148
9da90a0 
)

See: https://dev.mysql.com/doc/refman/5.7/en/show-create-database.html
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@lonng
parser: support show create database if not exists syntax (pingcap#148
b5b761d 
)

See: https://dev.mysql.com/doc/refman/5.7/en/show-create-database.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkyao winkyao winkyao left review comments

@crazycs520 crazycs520 crazycs520 approved these changes

@zier-one zier-one Awaiting requested review from zier-one

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
status/LGT2 LGT2 type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lonng @winkyao @crazycs520 @kennytm