Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: implement Restore for CreateTableStmt #170

Merged
merged 19 commits into from
Jan 15, 2019
Merged

parser: implement Restore for CreateTableStmt #170

merged 19 commits into from
Jan 15, 2019

Conversation

feloxx
Copy link
Contributor

@feloxx feloxx commented Jan 10, 2019

  1. CreateTableStmt
  2. TableOption
  3. PartitionDefinition
  4. PartitionOptions

Issue: pingcap/tidb#8532

@zier-one zier-one mentioned this pull request Jan 10, 2019
Closed
@kennytm kennytm mentioned this pull request Jan 10, 2019
Merged
@zier-one zier-one added the WIP label Jan 11, 2019
@zier-one zier-one removed the WIP label Jan 13, 2019
zier-one
zier-one reviewed Jan 13, 2019
View reviewed changes
ast/ddl.go Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
ast/ddl_test.go Show resolved Hide resolved
parser.y Outdated Show resolved Hide resolved
parser_test.go Outdated Show resolved Hide resolved
parser_test.go Outdated Show resolved Hide resolved
parser_test.go Outdated Show resolved Hide resolved
parser_test.go Outdated Show resolved Hide resolved
parser_test.go Outdated Show resolved Hide resolved
@zier-one
Copy link
Contributor

@kennytm
PTAL

zier-one
zier-one reviewed Jan 15, 2019
View reviewed changes
parser.go Outdated Show resolved Hide resolved
zier-one
zier-one reviewed Jan 15, 2019
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one
Copy link
Contributor

PTAL
@kennytm

@zier-one zier-one added the status/LGT1 LGT1 label Jan 15, 2019
zier-one
zier-one reviewed Jan 15, 2019
View reviewed changes
ast/ddl.go Outdated Show resolved Hide resolved
kennytm
kennytm reviewed Jan 15, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

ast/ddl.go Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
kennytm
kennytm reviewed Jan 15, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM.

@leoppro PTAL again for the latest commit.

ast/ddl.go Outdated Show resolved Hide resolved
@zier-one
Copy link
Contributor

LGTM

kennytm
kennytm previously approved these changes Jan 15, 2019
View reviewed changes
@kennytm kennytm added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Jan 15, 2019
@zier-one zier-one merged commit f562e1a into pingcap:master Jan 15, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@feloxx
parser: implement Restore for CreateTableStmt (pingcap#170)
dd9388b
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@feloxx
parser: implement Restore for CreateTableStmt (pingcap#170)
2d9c5cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one approved these changes

@kennytm kennytm kennytm left review comments

Assignees
No one assigned
Labels
contribution status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feloxx @zier-one @kennytm