Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model: add version number to Column #183

Merged
merged 6 commits into from
Jan 23, 2019
Merged

model: add version number to Column #183

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0e3a62b
model: add version number to TableInfo
crazycs520 Jan 17, 2019
d4e90e6
add version field in ColumnInfo
crazycs520 Jan 17, 2019
00b760a
Merge branch 'master' into tableinfo-version
crazycs520 Jan 18, 2019
8c3ce95
Merge branch 'master' into tableinfo-version
crazycs520 Jan 20, 2019
dca3cf4
address comment
crazycs520 Jan 20, 2019
43ae2ac
Merge branch 'master' into tableinfo-version
crazycs520 Jan 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions model/model.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,13 @@ func (s SchemaState) String() string {
}
}

const (
// ColumnInfoVersion0 means the column info version is 0.
ColumnInfoVersion0 = uint64(0)
// ColumnInfoVersion1 means the column info version is 1.
ColumnInfoVersion1 = uint64(1)
)

// ColumnInfo provides meta data describing of a table column.
type ColumnInfo struct {
ID int64 `json:"id"`
Expand All @@ -76,6 +83,12 @@ type ColumnInfo struct {
types.FieldType `json:"type"`
State SchemaState `json:"state"`
Comment string `json:"comment"`
// Version means the version of the column info.
// Version = 0: For OriginDefaultValue and DefaultValue of timestamp column will stores the default time in system time zone.
// There will be bug if multiple TiDB server in different system time zone.
crazycs520 marked this conversation as resolved.
Show resolved Hide resolved
// Version = 1: For OriginDefaultValue and DefaultValue of timestamp column will stores the default time in UTC time zone.
// This will fix bug in version 0. For compatibility with version 0, we add version field in column info struct.
Version uint64 `json:"version"`
}

// Clone clones ColumnInfo.
Expand Down